made drop down menu #90

2020-11-10T12:50:53+01:00

Yash-R commented

2020-11-10 12:50:53 +01:00

(Migrated from github.com)

resolved #81

Irev-Dev (Migrated from github.com) reviewed 2020-11-10 16:17:34 +01:00

Irev-Dev (Migrated from github.com) left a comment

A couple of minor things.
I've assigned you two some of my PRs, though I'm not necessarily expecting you to review them. It's more of a heads up for if you want take a look and leave and comments.
Same thing for your PRs, if you could assign them to me and give me a chance to have a look. If after a couple of days I haven't said anything happy for you to merge after that 👍

A couple of minor things. I've assigned you two some of my PRs, though I'm not necessarily expecting you to review them. It's more of a heads up for if you want take a look and leave and comments. Same thing for your PRs, if you could assign them to me and give me a chance to have a look. If after a couple of days I haven't said anything happy for you to merge after that 👍

web/src/layouts/MainLayout/MainLayout.js

						
				@@ -25,0 +28,4 @@

				  console.log(data?.user?.name);

				  const [isOpen, setIsOpen] = useState(false)

				  const [anchorEl, setAnchorEl] = useState(null)

				  const [popoverId, setPopoverId] = useState(undefined)

Irev-Dev (Migrated from github.com) commented

2020-11-10 16:13:39 +01:00

Lets try and remove console logs after we're done using them.

web/src/layouts/MainLayout/MainLayout.js

Irev-Dev (Migrated from github.com) commented

2020-11-10 16:12:58 +01:00

Like I said in the issue, I think this would be better as

anchorOrigin={{
    vertical: 'bottom',
    horizontal: 'right',
  }}
  transformOrigin={{
    vertical: 'top',
    horizontal: 'right',
  }}

Like I said in the issue, I think this would be better as ``` anchorOrigin={{ vertical: 'bottom', horizontal: 'right', }} transformOrigin={{ vertical: 'top', horizontal: 'right', }} ```

Yash-R (Migrated from github.com) reviewed 2020-11-10 17:17:30 +01:00

web/src/layouts/MainLayout/MainLayout.js

						
				@@ -25,0 +28,4 @@

				  console.log(data?.user?.name);

				  const [isOpen, setIsOpen] = useState(false)

				  const [anchorEl, setAnchorEl] = useState(null)

				  const [popoverId, setPopoverId] = useState(undefined)

Yash-R (Migrated from github.com) commented

2020-11-10 17:17:29 +01:00

okay

Yash-R (Migrated from github.com) reviewed 2020-11-10 17:17:58 +01:00

web/src/layouts/MainLayout/MainLayout.js

Yash-R (Migrated from github.com) commented

2020-11-10 17:17:58 +01:00

okay i will update this one

Irev-Dev commented

2020-11-10 21:42:05 +01:00

(Migrated from github.com)

@Yash-R I sent you an invite to edit the Figma design. Might be useful at some point.

👍 1

Yash-R commented

2020-11-10 22:04:09 +01:00

(Migrated from github.com)

@Irev-Dev I also wanted to ask that are you satisfied or did you liked my work?

Irev-Dev commented

2020-11-11 08:55:35 +01:00

(Migrated from github.com)

@Yash-R Absolutely. Like I said I'm glad you were able to put sensible amounts of padding in the dropdown menu. It might not seem like much but most devs don't have good design sense. You seem to be able to find your way around the project (even though I've made it a bit messy). Your work is quality ✨ .

I've been thinking about you helping out here with this project, and if possible I'd like to make sure you are benefiting from this in some way, I don't know you very well, but I know you're a student so I assume you want a career in software development. The fact that you're working on projects outside of studies says volumes about you, though I was thinking maybe there is some kind of feature or functionality that we can add to CadHub, but you'll "own" it, so to speak. So that down the track if nothing else you be able to use it as an example on your resume etc, as something in a live app that you built. 🤷 just ideas, thinking out loud.

Though that leads me to another point. It's a bit awkard having conversations in random github issues and PRs, so I set up a discord server if you wanna join in and chat. It will be only us in there for now. But hopefully, we can build a little crew in there.
discord link: https://discord.gg/57J4y4AR

@Yash-R Absolutely. Like I said I'm glad you were able to put sensible amounts of padding in the dropdown menu. It might not seem like much but most devs don't have good design sense. You seem to be able to find your way around the project (even though I've made it a bit messy). Your work is quality ✨ . I've been thinking about you helping out here with this project, and if possible I'd like to make sure you are benefiting from this in some way, I don't know you very well, but I know you're a student so I assume you want a career in software development. The fact that you're working on projects outside of studies says volumes about you, though I was thinking maybe there is some kind of feature or functionality that we can add to CadHub, but you'll "own" it, so to speak. So that down the track if nothing else you be able to use it as an example on your resume etc, as something in a live app that you built. 🤷 just ideas, thinking out loud. Though that leads me to another point. It's a bit awkard having conversations in random github issues and PRs, so I set up a discord server if you wanna join in and chat. It will be only us in there for now. But hopefully, we can build a little crew in there. discord link: https://discord.gg/57J4y4AR

❤️ 1

Yash-R commented

2020-11-11 11:33:35 +01:00

(Migrated from github.com)

@Irev-Dev you said all by yourself what I wanted to say, we'll talk more on discord now😀

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/cadhub#90