h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Some changes to the side tray to help make writing an issue for #540 #551

Merged
Irev-Dev merged 1 commits from kurt/540-prep into main 2021-10-10 22:46:42 +02:00
Conversation 2 Commits 1 Files Changed 1 +27 -22
1 changed files with 27 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

49
app/web/src/components/IdeSideBar/sidebarConfig.tsx
View File

@@ -63,12 +63,17 @@ const DiscordLink = () => (
</a>
)
const settingsConfig = [
interface settingsConfig {
title: string
name: string
Content: React.FC
}
const settingsConfig: settingsConfig[] = [
{
title: 'Editor',
name: 'editor',
open: false,
content: (
Content: () => (
<div className="p-2">
<p>
<em>Coming Soon</em>
Irev-Dev commented 2021-10-10 22:44:41 +02:00 (Migrated from github.com)
Review
Copy Link

Since these are going to contain buttons and other inputs, they really need to be components so they can access and dispatch to state.

Since these are going to contain buttons and other inputs, they really need to be components so they can access and dispatch to state.
@@ -84,8 +89,7 @@ const settingsConfig = [
{
title: 'Viewer',
name: 'viewer',
open: false,
content: (
Content: () => (
<div className="p-2">
<p>
<em>Coming Soon</em>
@@ -101,8 +105,7 @@ const settingsConfig = [
{
title: 'Console',
name: 'console',
open: false,
content: (
Content: () => (
<div className="p-2">
<p>
<em>Coming Soon</em>
@@ -135,24 +138,26 @@ function SettingsMenu({ parentName }: { parentName: string }) {
const { state, thunkDispatch } = useIdeContext()
return (
<article className="">
{settingsConfig.map((item) => (
{settingsConfig.map(({ name, title, Content }) => (
<details
key={'settings-tray-' + item.name}
open={state.sideTray.slice(-1)[0] === item.name}
onClick={(e) => {
e.preventDefault()
thunkDispatch((dispatch) =>
dispatch({
type: 'settingsButtonClicked',
payload: [parentName, item.name],
})
)
}}
key={'settings-tray-' + name}
open={state.sideTray.slice(-1)[0] === name}
>
<summary className="px-2 py-2 bg-ch-pink-800 bg-opacity-10 my-px cursor-pointer">
{item.title}
<summary
className="px-2 py-2 bg-ch-pink-800 bg-opacity-10 my-px cursor-pointer"
onClick={(e) => {
e.preventDefault()
thunkDispatch((dispatch) =>
dispatch({
type: 'settingsButtonClicked',
payload: [parentName, name],
})
)
}}
>
{title}
</summary>
{item.content}
<Content />
</details>
))}
</article>