h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Some changes to the side tray to help make writing an issue for #540 #551

Merged
Irev-Dev merged 1 commits from kurt/540-prep into main 2021-10-10 22:46:42 +02:00
Conversation 2 Commits 1 Files Changed 1 +27 -22
Irev-Dev commented 2021-10-10 22:43:36 +02:00 (Migrated from github.com)
Copy Link

Making the content into components will make writing a more descriptive issue for #540 easier. Going to merge @franknoirot so I can write up the issue.

Making the `content` into components will make writing a more descriptive issue for #540 easier. Going to merge @franknoirot so I can write up the issue.
❤️ 1
Irev-Dev (Migrated from github.com) reviewed 2021-10-10 22:44:41 +02:00
app/web/src/components/IdeSideBar/sidebarConfig.tsx
@@ -72,3 +76,4 @@
Content: () => (
<div className="p-2">
<p>
<em>Coming Soon</em>
Irev-Dev (Migrated from github.com) commented 2021-10-10 22:44:41 +02:00
Copy Link

Since these are going to contain buttons and other inputs, they really need to be components so they can access and dispatch to state.

Since these are going to contain buttons and other inputs, they really need to be components so they can access and dispatch to state.
Irev-Dev (Migrated from github.com) reviewed 2021-10-10 22:45:36 +02:00
app/web/src/components/IdeSideBar/sidebarConfig.tsx
Irev-Dev (Migrated from github.com) commented 2021-10-10 22:45:35 +02:00
Copy Link

Moved the onclick handler to the summary otherwise clicking anywhere in the side try would collapse that option.

Moved the onclick handler to the summary otherwise clicking anywhere in the side try would collapse that option.
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#551
Delete Branch "kurt/540-prep"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?