h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Start adding ide colors, includes adding custom theme to openscad #366

Merged
Irev-Dev merged 1 commits from kurt/color-tweaks-365 into main 2021-06-17 21:15:34 +02:00
Conversation 3 Commits 1 Files Changed 16 +209 -95
Irev-Dev commented 2021-06-16 13:49:16 +02:00 (Migrated from github.com)
Copy Link

Started to add colors but didn't go too crazy yet.
I was thinking @franknoirot is it worth adding the colors as "elements" in figma (not sure what the correct jargon is) but have the names match up between class names and names in figma?

Here's a screen shot.
image

This gap is going to be difficult to remove, as if I override the mosaic styles to remove the margin, than there's no gap between panels.
image

I decided against the save icon for when the button is labeled "preview" is that okay?
image

Resolves #365

Started to add colors but didn't go too crazy yet. I was thinking @franknoirot is it worth adding the colors as "elements" in figma (not sure what the correct jargon is) but have the names match up between class names and names in figma? Here's a screen shot. ![image](https://user-images.githubusercontent.com/29681384/122211105-b2f47880-cee9-11eb-84c9-5abb557b645d.png) This gap is going to be difficult to remove, as if I override the mosaic styles to remove the margin, than there's no gap between panels. ![image](https://user-images.githubusercontent.com/29681384/122211317-f0f19c80-cee9-11eb-895e-1e6c837304db.png) I decided against the save icon for when the button is labeled "preview" is that okay? ![image](https://user-images.githubusercontent.com/29681384/122211490-24342b80-ceea-11eb-90fc-69665a9ef9a1.png) Resolves #365
franknoirot (Migrated from github.com) reviewed 2021-06-16 13:49:16 +02:00
Irev-Dev (Migrated from github.com) reviewed 2021-06-16 13:53:58 +02:00
app/web/src/components/IdeContainer/IdeContainer.js
@@ -12,3 +30,2 @@
const ELEMENT_MAP = {
Editor: <IdeEditor />,
Viewer: <IdeViewer />,
Editor: (
Irev-Dev (Migrated from github.com) commented 2021-06-16 13:53:58 +02:00
Copy Link

https://user-images.githubusercontent.com/29681384/122214251-395e8980-ceed-11eb-94d9-fa7164613679.mov

Not completely happy with this, I think having two loading animations is not the best, but I also liked the big pink ping for the viewer, but it seemed wrong to use the same one for the editor.

https://user-images.githubusercontent.com/29681384/122214251-395e8980-ceed-11eb-94d9-fa7164613679.mov Not completely happy with this, I think having two loading animations is not the best, but I also liked the big pink ping for the viewer, but it seemed wrong to use the same one for the editor.
Irev-Dev (Migrated from github.com) reviewed 2021-06-16 13:57:40 +02:00
app/web/tailwind.config.js
@@ -13,0 +16,4 @@
colors: {
'ch-gray': {
900: '#0D0D13',
800: '#1A1A1D',
Irev-Dev (Migrated from github.com) commented 2021-06-16 13:57:40 +02:00
Copy Link

Colors I've added so far

Colors I've added so far
Sign in to join this conversation.
Reviewers
No Reviewers
franknoirot
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#366
Delete Branch "kurt/color-tweaks-365"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?