feat: allow non-github klipper repositories, as well as ssh cloning #452

2024-03-19T04:02:34+01:00

o080o commented

2024-03-19 04:02:34 +01:00

(Migrated from github.com)

This change allows users to use Klipper repositories other than github.com, including gitlab.com.

This addresses #398 as well as including the functionality from the open PR #323 regarding ssh cloning (since, they both touch the same line of code, in effectively the same way)

This change allows users to use Klipper repositories other than github.com, including gitlab.com. This addresses #398 as well as including the functionality from the open PR #323 regarding ssh cloning (since, they both touch the same line of code, in effectively the same way)

hg42 commented

2024-05-06 20:05:20 +02:00

(Migrated from github.com)

I generally think, kiuah should not mess with the repo url at all.
My own current patch just removes the sed command to remove the github from the url, but for compatibility I add https://github/, if the url does not contain ://.
I just wanted to create a pull request, but then saw this one.

I generally think, kiuah should not mess with the repo url at all. My own current patch just removes the sed command to remove the github from the url, but for compatibility I add `https://github/`, if the url does not contain `://`. I just wanted to create a pull request, but then saw this one.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin o080o/master:o080o/master

git checkout o080o/master

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#452