Ssh cloning #323

2023-03-31T11:10:06+02:00

viappidu commented

2023-03-31 11:10:06 +02:00

(Migrated from github.com)

Checking if cloning will be done via ssh

👎 1

northrup commented

2023-05-15 21:21:48 +02:00

(Migrated from github.com)

@viappidu is there a reason you'd want to introduce SSH based cloning? The potential problem I see with is that it would require users to have an SSH key generated for the user the process is running under in order to clone the repos versus https cloning of a public repo which requires no such setup.

viappidu commented

2023-05-16 10:12:13 +02:00

(Migrated from github.com)

I understand your concerns, and you are right though I use private
repositories and have already running agents with my keys. I actually can
only ssh to my repositories...

On Mon, May 15, 2023, 9:21 PM John Northrup @.***>
wrote:

@viappidu https://github.com/viappidu is there a reason you'd want to
introduce SSH based cloning? The potential problem I see with is that it
would require users to have an SSH key generated for the user the process
is running under in order to clone the repos versus https cloning of a
public repo which requires no such setup.

—
Reply to this email directly, view it on GitHub
https://github.com/th33xitus/kiauh/pull/323#issuecomment-1548439168, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKLJHTY337D6YGSW6M2NGLXGJ65PANCNFSM6AAAAAAWOMEWH4
.
You are receiving this because you were mentioned.Message ID:
@.***>

I understand your concerns, and you are right though I use private repositories and have already running agents with my keys. I actually can only ssh to my repositories... On Mon, May 15, 2023, 9:21 PM John Northrup ***@***.***> wrote: > @viappidu <https://github.com/viappidu> is there a reason you'd want to > introduce SSH based cloning? The potential problem I see with is that it > would require users to have an SSH key generated for the user the process > is running under in order to clone the repos versus https cloning of a > public repo which requires no such setup. > > — > Reply to this email directly, view it on GitHub > <https://github.com/th33xitus/kiauh/pull/323#issuecomment-1548439168>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAKLJHTY337D6YGSW6M2NGLXGJ65PANCNFSM6AAAAAAWOMEWH4> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

hg42 commented

2024-05-06 20:02:38 +02:00

(Migrated from github.com)

here a reason you'd want to introduce SSH based cloning

I also happen to use my own local repo to combine multiple external sources.
I could put them on github, but it's too special and usually it's temporary (e.g. when debugging, I change some lines and merge the other repos).

Users that use a git repo via ssh, will also know how to solve the key problem.
Normal users are not affected.

Additionally there are several other possibilities, github isn't the only public git site, think of gitlab etc.
I generally think, kiuah should not mess with the repo url at all.

> here a reason you'd want to introduce SSH based cloning I also happen to use my own local repo to combine multiple external sources. I could put them on github, but it's too special and usually it's temporary (e.g. when debugging, I change some lines and merge the other repos). Users that use a git repo via ssh, will also know how to solve the key problem. Normal users are not affected. Additionally there are several other possibilities, github isn't the only public git site, think of gitlab etc. I generally think, kiuah should not mess with the repo url at all.

This pull request has changes conflicting with the target branch.

scripts/klipper.sh

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin viappidu/ssh_cloning:viappidu/ssh_cloning

git checkout viappidu/ssh_cloning

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#323