fix(crowsnest): override installers BASE_USER to current user #317

2023-03-18T18:56:59+01:00

piotrb commented

2023-03-18 18:56:59 +01:00

(Migrated from github.com)

The crowsnest installer used logname to figure out the current user, this isn't great since it will return the "original" owner of the login session, so if you used sudo or su to become your klipper user .. it would try to install things into your original user making a bit of a mess ...

The symptoms show up similar to https://github.com/th33xitus/kiauh/issues/302 (not enough details in there to say its exactly the same)

The crowsnest installer used `logname` to figure out the current user, this isn't great since it will return the "original" owner of the login session, so if you used `sudo` or `su` to become your klipper user .. it would try to install things into your original user making a bit of a mess ... The symptoms show up similar to https://github.com/th33xitus/kiauh/issues/302 (not enough details in there to say its exactly the same)

dw-0 commented

2023-03-18 19:18:30 +01:00

(Migrated from github.com)

Thanks for the PR. Lets wait a few days with merging, maybe there is some feedback to your question in #302. But im interested to merge it, so thank you for your contribution in advance!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#317