feat(octoeverywhere): implement update function #310

Merged
dw-0 merged 2 commits from oe-updater into master 2023-03-11 20:25:17 +01:00
dw-0 commented 2023-03-10 19:59:18 +01:00 (Migrated from github.com)
No description provided.
QuinnDamerell (Migrated from github.com) reviewed 2023-03-11 00:23:46 +01:00
QuinnDamerell (Migrated from github.com) commented 2023-03-11 00:18:33 +01:00

I assume this name was just never updated for generic git clone, and it's not oversight?

I assume this name was just never updated for generic git clone, and it's not oversight?
@@ -279,0 +276,4 @@
do_action_service "stop" "octoeverywhere"
if [[ ! -d ${OCTOEVERYWHERE_DIR} ]]; then
clone_octoeverywhere "${OCTOEVERYWHERE_REPO}"
QuinnDamerell (Migrated from github.com) commented 2023-03-11 00:16:41 +01:00

Will this handle the octoeveryhere-* other possible service names?

Will this handle the octoeveryhere-* other possible service names?
@@ -279,0 +287,4 @@
"${OCTOEVERYWHERE_ENV}"/bin/pip install -r "${OCTOEVERYWHERE_DIR}/requirements.txt"
fi
ok_msg "Update complete!"
QuinnDamerell (Migrated from github.com) commented 2023-03-11 00:19:49 +01:00

I don't know much about virtual environments, but I assume this installs into it? The only way I have interactive with virtual envs is by using the /bin/activate the script.

I don't know much about virtual environments, but I assume this installs into it? The only way I have interactive with virtual envs is by using the /bin/activate the script.
@@ -279,0 +309,4 @@
function install_octoeverywhere_dependencies() {
local packages
local install_script="${OCTOEVERYWHERE_DIR}/install.sh"
QuinnDamerell (Migrated from github.com) commented 2023-03-11 00:23:25 +01:00

This is great!

This is great!
dw-0 (Migrated from github.com) reviewed 2023-03-11 08:37:52 +01:00
@@ -279,0 +276,4 @@
do_action_service "stop" "octoeverywhere"
if [[ ! -d ${OCTOEVERYWHERE_DIR} ]]; then
clone_octoeverywhere "${OCTOEVERYWHERE_REPO}"
dw-0 (Migrated from github.com) commented 2023-03-11 08:37:52 +01:00

Yes, calling that function handles all services beginning with "octoeverywhere".

Yes, calling that function handles all services beginning with "octoeverywhere".
dw-0 (Migrated from github.com) reviewed 2023-03-11 08:38:33 +01:00
dw-0 (Migrated from github.com) commented 2023-03-11 08:38:33 +01:00

Oops, nope, thats something i have to fix.

Oops, nope, thats something i have to fix.
dw-0 (Migrated from github.com) reviewed 2023-03-11 08:39:29 +01:00
@@ -279,0 +287,4 @@
"${OCTOEVERYWHERE_ENV}"/bin/pip install -r "${OCTOEVERYWHERE_DIR}/requirements.txt"
fi
ok_msg "Update complete!"
dw-0 (Migrated from github.com) commented 2023-03-11 08:39:29 +01:00

Correct, i added the evn you create during setup to the global variables and with that command i just run pip from that env and install possible new python deps into that specific env.

Correct, i added the evn you create during setup to the global variables and with that command i just run pip from that env and install possible new python deps into that specific env.
QuinnDamerell commented 2023-03-11 17:25:00 +01:00 (Migrated from github.com)

Looks great, thanks for doing this!

Looks great, thanks for doing this!
QuinnDamerell commented 2023-03-11 20:25:51 +01:00 (Migrated from github.com)

👏

👏
Sign in to join this conversation.