feat: replace mjpg-streamer with crowsnest #286

Merged
KwadFan merged 13 commits from feat/crowsnest into master 2023-02-03 22:00:00 +01:00
7 changed files with 266 additions and 12 deletions

View File

@@ -2,6 +2,12 @@
This document covers possible important changes to KIAUH.
### 2023-02-03
The installer for MJPG-Streamer got replaced by crowsnest. It is an improved webcam service, utilizing ustreamer.
Please have a look here for additional info about crowsnest and how to configure it: https://github.com/mainsail-crew/crowsnest \
It's unsure if the previous MJPG-Streamer installer will be updated and make its way back into KIAUH.
A big thanks to [KwadFan](https://github.com/KwadFan) for writing the crowsnest implementation.
### 2022-10-31
Some functions got updated, though not all of them.

241
scripts/crowsnest.sh Normal file
View File

@@ -0,0 +1,241 @@
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
#!/usr/bin/env bash
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
#=======================================================================#
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Copyright (C) 2020 - 2022 Dominik Willner <th33xitus@gmail.com> #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# This file is part of KIAUH - Klipper Installation And Update Helper #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# https://github.com/th33xitus/kiauh #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# This file may be distributed under the terms of the GNU GPLv3 license #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
#=======================================================================#
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
#=======================================================================#
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Crowsnest Installer brought to you by KwadFan <me@stephanwe.de> #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Copyright (C) 2022 KwadFan <me@stephanwe.de> #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# https://github.com/KwadFan/crowsnest #
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
#=======================================================================#
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Error Handling
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
set -e
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Helper messages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function multi_instance_message(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "Crowsnest is NOT designed to support multi instances."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "A workaround for this is to choose the most used instance as a 'master'"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "Use this instance to set up your 'crowsnest.conf' and steering it's service.\n"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "Found the following instances:\n"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
for i in ${1}; do
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
select_msg "${i}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
done
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "\nLaunching crowsnest's configuration tool ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
continue_config
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Helper funcs
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function clone_crowsnest(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
$(command -v git) clone "${CROWSNEST_REPO}" -b master "${CROWSNEST_DIR}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function check_multi_instance(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local -a instances
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
readarray -t instances < <(find "${HOME}" -regex "${HOME}/[a-zA-Z0-9_]+_data/*" -printf "%P\n" 2> /dev/null | sort)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ "${#instances[@]}" -gt 1 ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Multi instance install detected ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
multi_instance_message "${instances[*]}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ -d "${HOME}/crowsnest" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pushd "${HOME}/crowsnest" &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! make config ;then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Something went wrong! Please try again..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ -f "tools/.config" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
rm -f tools/.config
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ ! -f "tools/.config" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while generating .config"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Generating .config failed, installation aborted"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
popd &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function continue_config() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local reply
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
while true; do
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
read -erp "${cyan}###### Continue with configuration? (y/N):${white} " reply
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
case "${reply}" in
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
Y|y|Yes|yes)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
select_msg "Yes"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
break;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
N|n|No|no|"")
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
select_msg "No"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
warn_msg "Installation aborted by user ... Exiting!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
*)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Invalid Input!\n";;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
esac
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
done
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
return 0
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Install func
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function install_crowsnest(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 1: jump to home directory
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pushd "${HOME}" &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 2: Clone crowsnest repo
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Cloning 'crowsnest' repository ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ ! -d "${HOME}/crowsnest" && -z "$(ls -A "${HOME}/crowsnest" 2> /dev/null)" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
clone_crowsnest
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
ok_msg "crowsnest repository already exists ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 3: Install dependencies
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
dependency_check git make
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 4: Check for Multi Instance
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
check_multi_instance
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 5: Launch crowsnest installer
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pushd "${HOME}/crowsnest" &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
title_msg "Installer will prompt you for sudo password!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Launching crowsnest installer ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo make install; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Something went wrong! Please try again..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 5: Leave directory (twice due two pushd)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
popd &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
popd &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Remove func
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function remove_crowsnest(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pushd "${HOME}/crowsnest" &> /dev/null || exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
title_msg "Uninstaller will prompt you for sudo password!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Launching crowsnest uninstaller ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! make uninstall; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Something went wrong! Please try again..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ -e "${CROWSNEST_DIR}" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Removing crowsnest directory ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
rm -rf "${CROWSNEST_DIR}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
ok_msg "Directory removed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Status funcs
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
get_crowsnest_status(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local -a files
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
files=(
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
"${CROWSNEST_DIR}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
"/usr/local/bin/crowsnest"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
"/etc/logrotate.d/crowsnest"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
"/etc/systemd/system/crowsnest.service"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
"$(find "${HOME}" -name 'crowsnest.env' 2> /dev/null ||
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${HOME}/printer_data/systemd/crowsnest.env")"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Contains ugly hackaround for multi instance... :(
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local count
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
count=0
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
for file in "${files[@]}"; do
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
[[ -e "${file}" ]] && count=$(( count +1 ))
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
done
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ "${count}" -eq "${#files[*]}" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "Installed"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
elif [[ "${count}" -gt 0 ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "Incomplete!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "Not installed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Update funcs
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Shameless stolen from KlipperScreen.sh
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function get_local_crowsnest_commit() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
[[ ! -d ${CROWSNEST_DIR} || ! -d "${CROWSNEST_DIR}/.git" ]] && return
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local commit
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
cd "${CROWSNEST_DIR}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
commit="$(git describe HEAD --always --tags | cut -d "-" -f 1,2)"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${commit}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function get_remote_crowsnest_commit() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
[[ ! -d ${CROWSNEST_DIR} || ! -d "${CROWSNEST_DIR}/.git" ]] && return
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local commit
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
cd "${CROWSNEST_DIR}" && git fetch origin -q
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
commit=$(git describe origin/master --always --tags | cut -d "-" -f 1,2)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${commit}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function compare_crowsnest_versions() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local versions local_ver remote_ver
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local_ver="$(get_local_crowsnest_commit)"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
remote_ver="$(get_remote_crowsnest_commit)"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ ${local_ver} != "${remote_ver}" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
versions="${yellow}$(printf " %-14s" "${local_ver}")${white}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# add moonraker to application_updates_available in kiauh.ini
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
add_to_application_updates "crowsnest"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
versions="${green}$(printf " %-14s" "${local_ver}")${white}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${versions}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function install_crowsnest_dependencies() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local install_script="${CROWSNEST_DIR}/tools/install.sh"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### read PKGLIST from official install-script
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Reading dependencies..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# shellcheck disable=SC2016
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
packages="$(grep "PKGLIST=" "${install_script}" | cut -d'"' -f2 | sed 's/\${PKGLIST}//g' | tr -d '\n')"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${cyan}${packages}${white}" | tr '[:space:]' '\n'
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
read -r -a packages <<< "${packages}"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### Update system package info
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Updating package lists..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get update --allow-releaseinfo-change; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while updating package lists"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Updating package lists failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### Install required packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Installing required packages..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get install --yes "${packages[@]}"; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while installing required crowsnest packages"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Installing required packages failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function update_crowsnest() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
do_action_service "stop" "crowsnest"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ ! -d ${CROWSNEST_DIR} ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
clone_crowsnest
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Updating Crowsnest ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
cd "${CROWSNEST_DIR}" && git pull
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### read PKGLIST and install possible new dependencies
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
install_crowsnest_dependencies
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
ok_msg "Update complete!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
do_action_service "restart" "crowsnest"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

View File

@@ -68,4 +68,9 @@ function set_globals() {
#=============== MOONRAKER-OBICO ================#
MOONRAKER_OBICO_DIR="${HOME}/moonraker-obico"
MOONRAKER_OBICO_REPO="https://github.com/TheSpaghettiDetective/moonraker-obico.git"
#=============== Crowsnest ================#
CROWSNEST_DIR="${HOME}/crowsnest"
CROWSNEST_REPO="https://github.com/mainsail-crew/crowsnest.git"
}

View File

@@ -27,10 +27,8 @@ function install_ui() {
echo -e "| 3) [Mainsail] | 8) [Telegram Bot] |"
echo -e "| 4) [Fluidd] | 9) $(obico_install_title) |"
echo -e "| | |"
echo -e "| Touchscreen GUI: | |"
echo -e "| 5) [KlipperScreen] | |"
# echo -e "| Touchscreen GUI: | Webcam Streamer: |"
# echo -e "| 5) [KlipperScreen] | 10) [MJPG-Streamer] |"
echo -e "| Touchscreen GUI: | Webcam Streamer: |"
echo -e "| 5) [KlipperScreen] | 10) [Crowsnest] |"
back_footer
}
@@ -66,11 +64,8 @@ function install_menu() {
do_action "telegram_bot_setup_dialog" "install_ui";;
9)
do_action "moonraker_obico_setup_dialog" "install_ui";;
# 10)
# do_action "install_mjpg-streamer" "install_ui";;
# clear && print_header
# print_error "Function currently disabled! Sorry!"
# install_ui;;
10)
do_action "install_crowsnest" "install_ui";;
B|b)
clear; main_menu; break;;
*)

View File

@@ -29,6 +29,7 @@ function main_ui() {
echo -e "| | Fluidd: $(print_status "fluidd")|"
echo -e "| | KlipperScreen: $(print_status "klipperscreen")|"
echo -e "| 6) [Settings] | Telegram Bot: $(print_status "telegram_bot")|"
echo -e "| | Crowsnest: $(print_status "crowsnest")|"
echo -e "| | Obico: $(print_status "moonraker_obico")|"
echo -e "| | |"
echo -e "| $(print_kiauh_version)| Octoprint: $(print_status "octoprint")|"
@@ -107,6 +108,9 @@ function main_menu() {
"start octoprint") do_action_service "start" "octoprint"; main_ui;;
"stop octoprint") do_action_service "stop" "octoprint"; main_ui;;
"restart octoprint") do_action_service "restart" "octoprint"; main_ui;;
"start crowsnest") do_action_service "start" "crowsnest"; main_ui;;
"stop crowsnest") do_action_service "stop" "crowsnest"; main_ui;;
"restart crowsnest") do_action_service "restart" "crowsnest"; main_ui;;
update) do_action "update_kiauh" "main_ui";;
0)clear && print_header
#upload_selection

View File

@@ -21,7 +21,7 @@ function remove_ui() {
echo -e "| 1) [Klipper] | 6) [OctoPrint] |"
echo -e "| 2) [Moonraker] | |"
echo -e "| | Webcam Streamer: |"
echo -e "| Klipper Webinterface: | 7) [MJPG-Streamer] |"
echo -e "| Klipper Webinterface: | 7) [Crowsnest] |"
echo -e "| 3) [Mainsail] | |"
echo -e "| 4) [Fluidd] | Other: |"
echo -e "| | 8) [PrettyGCode] |"
@@ -51,7 +51,7 @@ function remove_menu() {
6)
do_action "remove_octoprint" "remove_ui";;
7)
do_action "remove_mjpg-streamer" "remove_ui";;
do_action "remove_crowsnest" "remove_ui";;
8)
do_action "remove_prettygcode" "remove_ui";;
9)

View File

@@ -32,8 +32,9 @@ function update_ui() {
echo -e "| 6) [PrettyGCode] |$(compare_prettygcode_versions)|"
echo -e "| 7) [Telegram Bot] |$(compare_telegram_bot_versions)|"
echo -e "| 8) [Obico for Klipper]|$(compare_moonraker_obico_versions)|"
echo -e "| 9) [Crowsnest] |$(compare_crowsnest_versions)|"
echo -e "| |------------------------------|"
echo -e "| 9) [System] | $(check_system_updates) |"
echo -e "| 10)[System] | $(check_system_updates) |"
back_footer
}
@@ -63,6 +64,8 @@ function update_menu() {
8)
do_action "update_moonraker_obico" "update_ui";;
9)
do_action "update_crowsnest" "update_ui";;
10)
do_action "update_system" "update_ui";;
a)
do_action "update_all" "update_ui";;