h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: replace mjpg-streamer with crowsnest #286

Merged
KwadFan merged 13 commits from feat/crowsnest into master 2023-02-03 22:00:00 +01:00
Conversation 5 Commits 13 Files Changed 7 +24 -25
1 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ce67e8ddb3 - Show all commits

49
scripts/crowsnest.sh
View File

@@ -196,37 +196,36 @@ function compare_crowsnest_versions() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${versions}"
}
function update_crowsnest() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
## Helper Func
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function install_crowsnest_dependencies() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local install_script="${CROWSNEST_DIR}/tools/install.sh"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function install_crowsnest_dependencies() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
local install_script="${CROWSNEST_DIR}/tools/install.sh"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### read PKGLIST from official install-script
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Reading dependencies..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# shellcheck disable=SC2016
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
packages="$(grep "PKGLIST=" "${install_script}" | cut -d'"' -f2 | sed 's/\${PKGLIST}//g' | tr -d '\n')"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### read PKGLIST from official install-script
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Reading dependencies..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# shellcheck disable=SC2016
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
packages="$(grep "PKGLIST=" "${install_script}" | cut -d'"' -f2 | sed 's/\${PKGLIST}//g' | tr -d '\n')"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${cyan}${packages}${white}" | tr '[:space:]' '\n'
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "${cyan}${packages}${white}" | tr '[:space:]' '\n'
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
read -r -a packages <<< "${packages}"
### Update system package info
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Updating package lists..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get update --allow-releaseinfo-change; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while updating package lists"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Updating package lists failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### Update system package info
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Updating package lists..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get update --allow-releaseinfo-change; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while updating package lists"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Updating package lists failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### Install required packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Installing required packages..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get install --yes "${packages[@]}"; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while installing required crowsnest packages"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Installing required packages failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
### Install required packages
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
status_msg "Installing required packages..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if ! sudo apt-get install --yes "${packages[@]}"; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
log_error "failure while installing required crowsnest packages"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Installing required packages failed!"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
fi
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
function update_crowsnest() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
do_action_service "stop" "crowsnest"
if [[ ! -d ${CROWSNEST_DIR} ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁