h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: replace mjpg-streamer with crowsnest #286

Merged
KwadFan merged 13 commits from feat/crowsnest into master 2023-02-03 22:00:00 +01:00
Conversation 5 Commits 13 Files Changed 7 +10 -14
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1221220f7d - Show all commits

24
scripts/crowsnest.sh
View File

@@ -70,16 +70,15 @@ function continue_config() {
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
while true; do
read -erp "${cyan}###### Continuing with configuration? (y/N):${white} " reply
case "${reply}" in
[Yy]* )
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
break
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
[Nn]* )
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
Y|y|Yes|yes)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
select_msg "Yes"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
break;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
N|n|No|no|"")
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
select_msg "No"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
warn_msg "Installation aborted by user ... Exiting!"
exit 1
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
* )
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo -e "\e[31mERROR: Please type Y or N !\e[0m"
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
exit 1;;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
*)
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
error_msg "Invalid Input!\n";;
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
esac
done
return 0
@@ -93,16 +92,13 @@ function install_crowsnest(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# Step 2: Clone crowsnest repo
status_msg "Cloning 'crowsnest' repository ..."
if [[ ! -d "${HOME}/crowsnest" ]] &&
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
[[ -z "$(ls -A "${HOME}/crowsnest")" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
if [[ ! -d "${HOME}/crowsnest" && -z "$(ls -A "${HOME}/crowsnest")" ]]; then
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
clone_crowsnest
else
ok_msg "crowsnest repository already exists ..."
fi
# Step 3: Install dependencies
# status_msg "Install basic dependencies ..."
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
# install_basic_deps
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
dependency_check git make
# Step 4: Check for Multi Instance
@@ -159,7 +155,7 @@ get_crowsnest_status(){
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "Installed"
elif [[ "${count}" -gt 0 ]]; then
echo "Incomplete!"
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
else
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
echo "Not installed!"
fi
}
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
pedrolamas commented 2023-01-14 12:40:39 +01:00 (Migrated from github.com)
Review
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
KwadFan commented 2023-01-19 15:59:41 +01:00 (Migrated from github.com)
Review
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
pedrolamas commented 2023-01-19 16:01:04 +01:00 (Migrated from github.com)
Review
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁