h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

refactor(klipper): recommend Python3 for Klipper installation #246

Merged
CODeRUS merged 1 commits from CODeRUS-patch-1 into master 2022-12-07 18:42:51 +01:00
Conversation 4 Commits 1 Files Changed 1 +6 -6
CODeRUS commented 2022-10-20 21:39:51 +02:00 (Migrated from github.com)
Copy Link

Nowadays there is no reason to use Python 2. Current distros doesnt have python 2 support, also python 2 klipper installation lacks of unicode file support.
Let users to install python2 version of klipper for old os-es if they need.

Nowadays there is no reason to use Python 2. Current distros doesnt have python 2 support, also python 2 klipper installation lacks of unicode file support. Let users to install python2 version of klipper for old os-es if they need.
🚀 3
dw-0 commented 2022-12-07 17:42:16 +01:00 (Migrated from github.com)
Copy Link

I think we can finally make that approach, yes. With the last release of Klipper, it was (afaik) actually the first time that it was officially announced, that Klipper supports python3, or at least that it now supports both py3 and py2, see:
https://klipper.discourse.group/t/klipper-v0-11-0-release/5143

I agree that we now should make py3 the recommended installation.
I see that there is a merge conflict. Would you like to resolve it?
And i would propose, that we not call python2 "outdated", how about calling it "legacy" or something? Im fine with marking python3 as the recommended one though.

I think we can finally make that approach, yes. With the last release of Klipper, it was (afaik) actually the first time that it was officially announced, that Klipper supports python3, or at least that it now supports both py3 and py2, see: https://klipper.discourse.group/t/klipper-v0-11-0-release/5143 I agree that we now should make py3 the recommended installation. I see that there is a merge conflict. Would you like to resolve it? And i would propose, that we not call python2 "outdated", how about calling it "legacy" or something? Im fine with marking python3 as the recommended one though.
👍 1
CODeRUS commented 2022-12-07 18:06:23 +01:00 (Migrated from github.com)
Copy Link

@th33xitus great, just did that

@th33xitus great, just did that
dw-0 (Migrated from github.com) approved these changes 2022-12-07 18:42:44 +01:00
dw-0 commented 2022-12-07 18:42:59 +01:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
🚀 1
Sign in to join this conversation.
Reviewers
No Reviewers
dw-0
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#246
Delete Branch "CODeRUS-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?