h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: KIAUH v4.0.0 #191

Merged
dw-0 merged 453 commits from v4-rc into master 2022-05-29 20:11:16 +02:00
Conversation 8 Commits 453 Files Changed 64 +6489 -5889
dw-0 commented 2022-04-24 15:49:14 +02:00 (Migrated from github.com)
Copy Link

Todo:

Testing required:

  • Debian 11
  • Raspberry Pi OS Lite Buster
  • Raspberry Pi OS Lite Bullseye
  • MainsailOS (latest)
  • FluiddPi (latest) (FluiddPi is currently not maintained)
  • Ubuntu Server 20.04
  • Ubuntu Desktop 20.04
  • Ubuntu Server 21.10
  • Ubuntu Desktop 21.10
  • Ubuntu Server 22.04
  • Ubuntu Desktop 22.04
  • DietPi Bullseye

Postponed (will be released later - no ETA):

  • Instance Manager (adding, removing, renaming instances)

Signed-off-by: Dominik Willner th33xitus@gmail.com

### Todo: - [x] custom instance names for Klipper (multi instance only) - [x] custom instance names for Moonraker (multi instance only) - [x] Multi instance installation for Telegram Bot - [x] custom instance names for Telegram Bot (multi instance only) - [x] fix for individual logfiles for Telegram Bot (waiting for changes in upstream) - [x] custom instance names for OctoPrint (multi instance only) - [x] https://github.com/th33xitus/kiauh/issues/195 - [x] https://github.com/th33xitus/kiauh/issues/193 - [x] https://github.com/th33xitus/kiauh/issues/182 - [x] https://github.com/th33xitus/kiauh/issues/194 ### Testing required: - [x] Debian 11 - [x] Raspberry Pi OS Lite Buster - [x] Raspberry Pi OS Lite Bullseye - [x] MainsailOS (latest) - [ ] ~~FluiddPi (latest)~~ (FluiddPi is currently not maintained) - [x] Ubuntu Server 20.04 - [x] Ubuntu Desktop 20.04 - [x] Ubuntu Server 21.10 - [x] Ubuntu Desktop 21.10 - [x] Ubuntu Server 22.04 - [x] Ubuntu Desktop 22.04 - [x] DietPi Bullseye ### Postponed (will be released later - no ETA): - Instance Manager (adding, removing, renaming instances) Signed-off-by: Dominik Willner th33xitus@gmail.com
🎉 1 🚀 1
th0m4sek commented 2022-04-25 17:57:45 +02:00 (Migrated from github.com)
Copy Link

working on armbian 22.02 (Orange Pi 3)

working on armbian 22.02 (Orange Pi 3)
dw-0 commented 2022-04-25 18:03:20 +02:00 (Migrated from github.com)
Copy Link

working on armbian 22.02 (Orange Pi 3)

Thank you for the feedback! Which functions did you test exactly?

> working on armbian 22.02 (Orange Pi 3) Thank you for the feedback! Which functions did you test exactly?
th0m4sek commented 2022-04-25 22:19:27 +02:00 (Migrated from github.com)
Copy Link

Klipper Moonraker and fluidd

Klipper Moonraker and fluidd
👍 1
clee (Migrated from github.com) reviewed 2022-05-04 07:21:48 +02:00
scripts/utilities.sh
clee (Migrated from github.com) commented 2022-05-04 07:21:48 +02:00
Copy Link
    sudo cp "/etc/hosts" "/etc/hosts.${current_date}.bak"
```suggestion sudo cp "/etc/hosts" "/etc/hosts.${current_date}.bak" ```
clee (Migrated from github.com) reviewed 2022-05-04 07:23:45 +02:00
scripts/utilities.sh
clee (Migrated from github.com) commented 2022-05-04 07:23:45 +02:00
Copy Link

I had to make this change in order to fix the error I got when I attempted to change the hostname (4/advanced, 7/change hostname from the menus) on armbian-22.05-trunk.

###### Creating backup of hosts file ...
cp: missing destination file operand after '/etc/hosts /etc/hosts.220503-2314.bak'
Try 'cp --help' for more information.
I had to make this change in order to fix the error I got when I attempted to change the hostname (4/advanced, 7/change hostname from the menus) on armbian-22.05-trunk. ``` ###### Creating backup of hosts file ... cp: missing destination file operand after '/etc/hosts /etc/hosts.220503-2314.bak' Try 'cp --help' for more information. ```
dw-0 (Migrated from github.com) reviewed 2022-05-05 10:14:02 +02:00
scripts/utilities.sh
dw-0 (Migrated from github.com) commented 2022-05-05 10:14:01 +02:00
Copy Link

Thank you! Yes that was indeed a typo and i just fixed it.

Thank you! Yes that was indeed a typo and i just fixed it.
5ilver (Migrated from github.com) reviewed 2022-06-02 20:16:34 +02:00
scripts/nginx.sh
@@ -0,0 +290,4 @@
sudo sed -i "/root/s/pi/${USER}/" "${cfg}"
fi
#moving the config file into correct directory
5ilver (Migrated from github.com) commented 2022-06-02 20:16:34 +02:00
Copy Link

This will require attention again in October when 22.10 comes out. Unless this change is harmful on 21.04 it may be better to just remove the version check altogether.

Perhaps the script could simply check if the nginx user has sufficient permission and run chmod if it does not? Unsure if things like selinux or other sandboxing may come into play here.

This will require attention again in October when 22.10 comes out. Unless this change is harmful on 21.04 it may be better to just remove the version check altogether. Perhaps the script could simply check if the nginx user has sufficient permission and run chmod if it does not? Unsure if things like selinux or other sandboxing may come into play here.
dw-0 (Migrated from github.com) reviewed 2022-06-02 20:25:16 +02:00
scripts/nginx.sh
@@ -0,0 +290,4 @@
sudo sed -i "/root/s/pi/${USER}/" "${cfg}"
fi
#moving the config file into correct directory
dw-0 (Migrated from github.com) commented 2022-06-02 20:25:15 +02:00
Copy Link

Fair point. Maybe not a bad idea indeed. Or at least something like checking if distro_name == "Ubuntu" and if that is the case i then check for the required permissions. Another way would be to check for major version greater than 20. Because up until Ubuntu 20, no permission changes are required.

Fair point. Maybe not a bad idea indeed. Or at least something like checking if `distro_name == "Ubuntu"` and if that is the case i then check for the required permissions. Another way would be to check for major version greater than `20`. Because up until Ubuntu 20, no permission changes are required.
Sign in to join this conversation.
Reviewers
No Reviewers
clee
5ilver
dw-0
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#191
Delete Branch "v4-rc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?