PR Submenu change from "quit" to "back" #111

2021-09-12T15:42:35+02:00

The-Monkey-King commented

2021-09-12 15:42:35 +02:00

(Migrated from github.com)

When I first ran the code, I went to advanced because I had klipper already installed and I wanted to see if I could install fluidd using this code base. So when see advanced menu I was concerned that "quit" meant quitting the tool instead of exiting the advanced menu. So proposing a back_footer for sub menus that will revert back to main menu. You would use the quit footer for main menu to exit program.

changed submenus to use back_footer
edited general_ui to add back_footer as a UI component

When I first ran the code, I went to advanced because I had klipper already installed and I wanted to see if I could install fluidd using this code base. So when see advanced menu I was concerned that "quit" meant quitting the tool instead of exiting the advanced menu. So proposing a back_footer for sub menus that will revert back to main menu. You would use the quit footer for main menu to exit program. changed submenus to use back_footer edited general_ui to add back_footer as a UI component

dw-0 (Migrated from github.com) requested changes 2021-09-12 19:52:54 +02:00

scripts/upload_log.sh

						
				@@ -75,3 +74,4 @@

				  back_footer

				  while true; do

				    read -p "${cyan}Please select:${default} " choice

				    if [ $choice = "q" ] || [ $choice = "Q" ]; then

dw-0 (Migrated from github.com) commented

2021-09-12 16:33:29 +02:00

we need to change the q/Q to b/B here too, otherwise we will introduce a bug :)

dw-0 (Migrated from github.com) reviewed 2021-09-12 19:53:36 +02:00

scripts/upload_log.sh

						
				@@ -75,3 +74,4 @@

				  back_footer

				  while true; do

				    read -p "${cyan}Please select:${default} " choice

				    if [ $choice = "q" ] || [ $choice = "Q" ]; then

dw-0 (Migrated from github.com) commented

2021-09-12 19:53:36 +02:00

Also pls see my previous comment: https://github.com/th33xitus/kiauh/pull/111#issuecomment-917646892

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#111