h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: replace mjpg-streamer with crowsnest #286

Merged
KwadFan merged 13 commits from feat/crowsnest into master 2023-02-03 22:00:00 +01:00
Conversation 5 Commits 13 Files Changed 7 +266 -12
KwadFan commented 2023-01-12 21:47:57 +01:00 (Migrated from github.com)
Copy Link

Signed-off-by: Stephan Wendel me@stephanwe.de

Signed-off-by: Stephan Wendel <me@stephanwe.de>
👍 3 👀 1 🎉 1
pedrolamas (Migrated from github.com) reviewed 2023-01-14 12:40:40 +01:00
scripts/crowsnest.sh
pedrolamas (Migrated from github.com) commented 2023-01-14 12:40:39 +01:00
Copy Link

Any specific reason as to why leave this here commented? Might as well just remove it, no?

Any specific reason as to why leave this here commented? Might as well just remove it, no?
KwadFan (Migrated from github.com) reviewed 2023-01-19 15:59:42 +01:00
scripts/crowsnest.sh
KwadFan (Migrated from github.com) commented 2023-01-19 15:59:41 +01:00
Copy Link

Well, obviously I was lost in my own code 🤣

No, will remove that asap

Well, obviously I was lost in my own code :rofl: No, will remove that asap
pedrolamas (Migrated from github.com) reviewed 2023-01-19 16:01:04 +01:00
scripts/crowsnest.sh
pedrolamas (Migrated from github.com) commented 2023-01-19 16:01:04 +01:00
Copy Link

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁

Nevertheless, I tried your PR and it "worked fine on my machine"! 😁
KwadFan commented 2023-01-19 16:06:55 +01:00 (Migrated from github.com)
Copy Link

Requested your Review @pedrolamas

Requested your Review @pedrolamas
pedrolamas (Migrated from github.com) approved these changes 2023-01-19 16:13:33 +01:00
pedrolamas (Migrated from github.com) left a comment
Copy Link

As far as I can see, this LGTM!

As far as I can see, this LGTM!
Sign in to join this conversation.
Reviewers
No Reviewers
KwadFan
pedrolamas
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#286
Delete Branch "feat/crowsnest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?