h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

added logo to navbar and favicon #57

Merged
pratskalive08 merged 2 commits from adding-logo into main 2020-10-31 11:46:07 +01:00
Conversation 6 Commits 2 Files Changed 4 +8 -3
pratskalive08 commented 2020-10-30 20:01:00 +01:00 (Migrated from github.com)
Copy Link

@Irev-Dev hope I got it right 😃

@Irev-Dev hope I got it right 😃
Irev-Dev (Migrated from github.com) requested changes 2020-10-30 22:09:03 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Thanks so much @pratskalive08, I love it.
the Preview looks really good.

I asked for one small change.

Is there any chance you could send me the original? would be useful if I need to make tweaks later, adjust the color or things of that nature?
You could either add it to the repo under assets or send it to me vie email k.hutten@protonmail.ch?

Thanks so much @pratskalive08, I love it. the [Preview](https://deploy-preview-57--cadhubxyz.netlify.app/) looks really good. I asked for one small change. Is there any chance you could send me the original? would be useful if I need to make tweaks later, adjust the color or things of that nature? You could either add it to the repo under assets or send it to me vie email k.hutten@protonmail.ch?
web/src/index.html
@@ -8,1 +7,4 @@
<link rel="icon" type="image/png" href="/favi2.jpg" />
<title><%= htmlWebpackPlugin.options.title %></title>
<script>
Irev-Dev (Migrated from github.com) commented 2020-10-30 21:05:27 +01:00
Copy Link

Could we Change this back to <title>CadHub</title> please?
I'm guessing this changed while you were working on it and you changed it back when resolving a conflict?
Either way would be good to have CadHub as the title of the website.

Could we Change this back to `<title>CadHub</title>` please? I'm guessing this changed while you were working on it and you changed it back when resolving a conflict? Either way would be good to have CadHub as the title of the website.
Irev-Dev (Migrated from github.com) reviewed 2020-10-30 22:13:44 +01:00
web/src/layouts/MainLayout/MainLayout.js
Irev-Dev (Migrated from github.com) commented 2020-10-30 22:13:44 +01:00
Copy Link

Could you also remove the style property and change it to className="ml-12", it should do the same thing.

Could you also remove the style property and change it to `className="ml-12"`, it should do the same thing.
Irev-Dev commented 2020-10-31 11:46:03 +01:00 (Migrated from github.com)
Copy Link

Hey @pratskalive08 I'm going to merge now as I don't want you to miss out on hacktoberfest, and I can fix up the changes myself later.

Though I would still like the original of the icon, would that be possible?

Hey @pratskalive08 I'm going to merge now as I don't want you to miss out on hacktoberfest, and I can fix up the changes myself later. Though I would still like the original of the icon, would that be possible?
pratskalive08 commented 2020-10-31 15:43:57 +01:00 (Migrated from github.com)
Copy Link

@Irev-Dev Thanks a ton! So sorry for the delay. As for the logo, I just mailed it to k.hutten@protonmail.ch.

@Irev-Dev Thanks a ton! So sorry for the delay. As for the logo, I just mailed it to k.hutten@protonmail.ch.
🎉 1
Irev-Dev commented 2020-12-10 09:11:21 +01:00 (Migrated from github.com)
Copy Link

Hey @pratskalive08,

Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker).

If you're keen you can send me a DM with your address on twitter or on discord. https://discord.gg/SD7zFRNjGH

unknown

Hey @pratskalive08, Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker). If you're keen you can send me a DM with your address on twitter or on discord. https://discord.gg/SD7zFRNjGH ![unknown](https://user-images.githubusercontent.com/29681384/101739328-74859780-3b1b-11eb-867d-aa80575e7176.png)
pratskalive08 commented 2020-12-10 23:42:35 +01:00 (Migrated from github.com)
Copy Link

Hey Kurt,

Thanks so much for asking! :) I'm based in India. Your profile says you're
based in Australia, and I'm assuming the postage would be a lot of effort,
given the situation right now. I wouldn't want to put you through all that.
Thanks for the gesture though, really appreciate it. :)

Regards,
Prathyusha

On Thu, 10 Dec 2020 at 13:41, Kurt Hutten notifications@github.com wrote:

Hey @pratskalive08 https://github.com/pratskalive08,

Some stickers I ordered finally arrived. Would you like one as a thankyou
for your help? (assuming postage doesn't cost me an arm and a leg but
should be fine for a sticker).

If you're keen you can send me a DM with your address on twitter or on
discord. https://discord.gg/SD7zFRNjGH

[image: unknown]
https://user-images.githubusercontent.com/29681384/101739328-74859780-3b1b-11eb-867d-aa80575e7176.png

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Irev-Dev/cadhub/pull/57#issuecomment-742356208, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AMSA3GAVGD5DAE5BK2YVQ4DSUB7DNANCNFSM4TFKH4NQ
.

Hey Kurt, Thanks so much for asking! :) I'm based in India. Your profile says you're based in Australia, and I'm assuming the postage would be a lot of effort, given the situation right now. I wouldn't want to put you through all that. Thanks for the gesture though, really appreciate it. :) Regards, Prathyusha On Thu, 10 Dec 2020 at 13:41, Kurt Hutten <notifications@github.com> wrote: > Hey @pratskalive08 <https://github.com/pratskalive08>, > > Some stickers I ordered finally arrived. Would you like one as a thankyou > for your help? (assuming postage doesn't cost me an arm and a leg but > should be fine for a sticker). > > If you're keen you can send me a DM with your address on twitter or on > discord. https://discord.gg/SD7zFRNjGH > > [image: unknown] > <https://user-images.githubusercontent.com/29681384/101739328-74859780-3b1b-11eb-867d-aa80575e7176.png> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/Irev-Dev/cadhub/pull/57#issuecomment-742356208>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AMSA3GAVGD5DAE5BK2YVQ4DSUB7DNANCNFSM4TFKH4NQ> > . >
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#57
Delete Branch "adding-logo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?