h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

side-tray-styles-patch #514

Merged
Irev-Dev merged 1 commits from side-tray-styles-patch into main 2021-09-18 09:33:41 +02:00
Conversation 3 Commits 1 Files Changed 2 +6 -17
Irev-Dev commented 2021-09-18 09:29:53 +02:00 (Migrated from github.com)
Copy Link

Merging now because styles are currently broken. Not sure why this is different when built vs dev.

image
To replicate checkout previous commit and yarn rw build && yarn rw serve

Merging now because styles are currently broken. Not sure why this is different when built vs dev. ![image](https://user-images.githubusercontent.com/29681384/133880416-cacc4b2b-b1f2-4bd9-a635-0e8967378691.png) To replicate checkout previous commit and `yarn rw build && yarn rw serve`
franknoirot (Migrated from github.com) reviewed 2021-09-18 09:29:53 +02:00
Irev-Dev (Migrated from github.com) reviewed 2021-09-18 09:33:24 +02:00
app/web/src/index.css
@@ -45,4 +35,1 @@
}
}
.three-debug-panel-1 {
Irev-Dev (Migrated from github.com) commented 2021-09-18 09:33:24 +02:00
Copy Link

Don't know why these didn't work.

Not sure I 100% love the pattern anyway since these styles are are very specific to one component and now completely seperate. I to optimize for delete-ability, and this would make it tricky to clean up app/web/src/components/IdeSideBar/IdeSideBar.tsx should we delete it down the track.

Do you think it would be better to add these classes into a new css file in app/web/src/components/IdeSideBar/IdeSideBar.css and import that directly into app/web/src/components/IdeSideBar/IdeSideBar.tsx instead @franknoirot?

Don't know why these didn't work. Not sure I 100% love the pattern anyway since these styles are are very specific to one component and now completely seperate. I to optimize for delete-ability, and this would make it tricky to clean up `app/web/src/components/IdeSideBar/IdeSideBar.tsx` should we delete it down the track. Do you think it would be better to add these classes into a new css file in `app/web/src/components/IdeSideBar/IdeSideBar.css` and import that directly into `app/web/src/components/IdeSideBar/IdeSideBar.tsx` instead @franknoirot?
franknoirot (Migrated from github.com) reviewed 2021-09-18 13:19:54 +02:00
app/web/src/index.css
@@ -45,4 +35,1 @@
}
}
.three-debug-panel-1 {
franknoirot (Migrated from github.com) commented 2021-09-18 13:19:54 +02:00
Copy Link

Yeah that's a good point, I think you're right having it local to the components directory is best.

Yeah that's a good point, I think you're right having it local to the components directory is best.
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
franknoirot
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#514
Delete Branch "side-tray-styles-patch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?