h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Add UserPart component #50

Merged
lyonsbp merged 3 commits from create-user-part into main 2020-10-28 19:26:31 +01:00
Conversation 6 Commits 3 Files Changed 1 +17
lyonsbp commented 2020-10-27 22:34:13 +01:00 (Migrated from github.com)
Copy Link

Resolves #48

Resolves #48
lyonsbp commented 2020-10-27 22:35:48 +01:00 (Migrated from github.com)
Copy Link

Example of the component in use on the home screen
Screen Shot 2020-10-27 at 5 34 24 PM

Example of the component in use on the home screen <img width="249" alt="Screen Shot 2020-10-27 at 5 34 24 PM" src="https://user-images.githubusercontent.com/6699191/97364690-c9769280-187a-11eb-8f22-2cf029d91997.png">
Irev-Dev (Migrated from github.com) requested changes 2020-10-28 10:26:48 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Thanks again for this @lyonsbp
I've asked for a few changes just to get it to be a bit more true to the designs.
image
Much of it is just color tweaks, (I'm guessing you had used your best guess at the colors, while the tailwind colors are setup in Figma, its understandable if you're not familir with figma).

Thanks again for this @lyonsbp I've asked for a few changes just to get it to be a bit more true to the designs. ![image](https://user-images.githubusercontent.com/29681384/97417327-a66fdf80-195b-11eb-9372-bdfd817db5b6.png) Much of it is just color tweaks, (I'm guessing you had used your best guess at the colors, while the tailwind colors are setup in Figma, its understandable if you're not familir with figma).
web/src/components/UserPart/UserPart.js
Irev-Dev (Migrated from github.com) commented 2020-10-28 10:15:42 +01:00
Copy Link

Could we make this indigo-800, please.

Could we make this indigo-800, please.
Irev-Dev (Migrated from github.com) commented 2020-10-28 10:18:28 +01:00
Copy Link

I would like this slash to be aligned at the top and bottom with the indigo bar at the start of the line,
and so I think you should probably use the same technique there and use skew.
https://tailwindcss.com/docs/skew#app.
It should also be gray-400

I would like this slash to be aligned at the top and bottom with the indigo bar at the start of the line, and so I think you should probably use the same technique there and use skew. https://tailwindcss.com/docs/skew#app. It should also be gray-400
Irev-Dev (Migrated from github.com) commented 2020-10-28 10:19:04 +01:00
Copy Link

indigo-800 here too please.

indigo-800 here too please.
Irev-Dev (Migrated from github.com) commented 2020-10-28 10:23:44 +01:00
Copy Link

I think font-roboto might be needed here too.

I think `font-roboto` might be needed here too.
lyonsbp commented 2020-10-28 16:15:03 +01:00 (Migrated from github.com)
Copy Link

Hi @Irev-Dev I pushed up some changes. I was having some trouble getting the skew classes working locally, but I tested in a sandbox and according to the tailwind docs those classes should be working.

Hi @Irev-Dev I pushed up some changes. I was having some trouble getting the `skew` classes working locally, but I tested in a sandbox and according to the tailwind docs those classes should be working.
Irev-Dev commented 2020-10-28 19:28:24 +01:00 (Migrated from github.com)
Copy Link

Thanks @lyonsbp, it turns out that skew doesn't work on inline elements. I got it working here.
https://github.com/Irev-Dev/cadhub/pull/53

Thanks @lyonsbp, it turns out that skew doesn't work on inline elements. I got it working here. https://github.com/Irev-Dev/cadhub/pull/53
lyonsbp commented 2020-10-28 20:42:03 +01:00 (Migrated from github.com)
Copy Link

Ohh the inline was the issue then. Thanks for fixing that, I appreciate it!

Ohh the inline was the issue then. Thanks for fixing that, I appreciate it!
🎉 1
Irev-Dev commented 2020-12-10 09:11:14 +01:00 (Migrated from github.com)
Copy Link

Hey @lyonsbp

Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker).

If you're keen you can send me a DM with your address on twitter or on discord. https://discord.gg/SD7zFRNjGH
unknown

Hey @lyonsbp Some stickers I ordered finally arrived. Would you like one as a thankyou for your help? (assuming postage doesn't cost me an arm and a leg but should be fine for a sticker). If you're keen you can send me a DM with your address on twitter or on discord. https://discord.gg/SD7zFRNjGH ![unknown](https://user-images.githubusercontent.com/29681384/101739209-54ee6f00-3b1b-11eb-95e5-c43862d8e9a3.png)
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#50
Delete Branch "create-user-part"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?