Initial keyboard shortcuts configuration implementation #496

Merged
franknoirot merged 11 commits from keyboard-shortcuts into main 2021-09-10 00:12:59 +02:00
5 changed files with 93205 additions and 13906 deletions
Showing only changes of commit e1d429877c - Show all commits

78437
app/package-lock.json generated Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -32,5 +32,9 @@
"engines": {
"node": ">=14",
"yarn": ">=1.15"
},
"dependencies": {
"hotkeys-js": "^3.8.7",
"react-hotkeys-hook": "^3.4.0"
}
}

View File

@@ -1,11 +1,12 @@
import { Menu } from '@headlessui/react'
import { useHotkeys } from 'react-hotkeys-hook';
import { useIdeContext } from 'src/helpers/hooks/useIdeContext'
import Svg from 'src/components/Svg/Svg'
import { useRender } from 'src/components/IdeWrapper/useRender'
import { makeStlDownloadHandler, PullTitleFromFirstLine } from './helpers'
import { useSaveCode } from 'src/components/IdeWrapper/useSaveCode'
import CadPackage from 'src/components/CadPackage/CadPackage'
import { EditorMenuConfig, EditorMenuItemConfig, editorMenuConfig } from './menuConfig'
const EditorMenu = () => {
const handleRender = useRender()
@@ -23,6 +24,12 @@ const EditorMenu = () => {
fileName: PullTitleFromFirstLine(state.code || ''),
thunkDispatch,
})
editorMenuConfig.forEach(menu =>
menu.items.forEach(({shortcut, callback}) =>
useHotkeys(shortcut, callback), [state])
)
return (
<div className="flex justify-between bg-ch-gray-760 text-gray-100">
<div className="flex items-center h-9 w-full cursor-grab">
@@ -30,16 +37,11 @@ const EditorMenu = () => {
<Svg name="drag-grid" className="w-4 p-px" />
</div>
<div className="grid grid-flow-col-dense gap-6 px-5">
<FileDropdown
handleRender={onRender}
handleStlDownload={handleStlDownload}
/>
<button className="cursor-not-allowed" disabled>
Edit
</button>
<ViewDropdown
handleLayoutReset={() => thunkDispatch({ type: 'resetLayout' })}
/>
{ editorMenuConfig.map(menu => (
<Dropdown label={menu.label} disabled={menu.disabled}>
{ menu.items.map(itemConfig => <DropdownItem config={itemConfig} key={ menu.label +"-"+ itemConfig.label} />) }
</Dropdown>
)) }
</div>
<button
className="text-ch-gray-300 h-full cursor-not-allowed"
@@ -113,20 +115,40 @@ function ViewDropdown({ handleLayoutReset }) {
)
}
function DropdownItem(config) {
return (
<Menu.Item>
{({ active }) => (
<button
className={`${active && 'bg-gray-600'} px-2 py-1 text-left`}
onClick={config.callback}
>
{config.label}
{config.shortcutLabel && <span className="text-gray-400 pl-4">{ config.shortcutLabel }</span> }
</button>
)}
</Menu.Item>
)
}
function Dropdown({
name,
label,
disabled,
children,
}: {
name: string
children: React.ReactNode
label: string,
disabled: boolean,
children: React.ReactNode,
}) {
return (
<div className="relative">
<Menu>
<Menu.Button className="text-gray-100">{name}</Menu.Button>
<Menu.Button className={"text-gray-100" + (disabled ? "cursor-not-allowed" : "")} disabled={disabled}>{label}</Menu.Button>
{ children &&
<Menu.Items className="absolute flex flex-col mt-4 bg-ch-gray-760 rounded text-gray-100 overflow-hidden whitespace-nowrap border border-ch-gray-700">
{children}
</Menu.Items>
}
</Menu>
</div>
)

View File

@@ -0,0 +1,68 @@
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
import React from 'react'
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
import Svg from 'src/components/Svg/Svg'
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
franknoirot commented 2021-09-08 16:39:40 +02:00 (Migrated from github.com)
Review

This won't work currently because I backed out of writing it, but @Irev-Dev should I use a React Context to make the AllShortcutsModal able to be opened from outside of the component? I could make its own little context to provide around the IdeWrapper component, or the page component itself. I might try that and see if you like it.

This won't work currently because I backed out of writing it, but @Irev-Dev should I use a React Context to make the `AllShortcutsModal` able to be opened from outside of the component? I could make its own little context to provide around the `IdeWrapper` component, or the page component itself. I might try that and see if you like it.
franknoirot commented 2021-09-08 17:39:09 +02:00 (Migrated from github.com)
Review

Tried this approach below.

Tried this approach below.
export const fileMenuConfig = [
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
{
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: 'Cook Donut',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcut: 'ctrl+d, command+d',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcutLabel: <><CmdOrCtrl/> D</>,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
callback: () => alert('Donut is cooked!'),
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
}
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
]
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
export const viewMenuConfig = [
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
{
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: 'Reset layout',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcut: 'ctrl+alt+r, command+alt+r',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcutLabel: <><CmdOrCtrl/> Alt R</>,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
callback: () => alert('Resetting the layout!'),
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
}
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
]
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
export const editorMenuConfig = [
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
{
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
name: 'file',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: 'File',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
disabled: false,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
items: fileMenuConfig,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
},
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
{
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
name: 'edit',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: 'Edit',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
disabled: true,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
items: [],
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
},
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
{
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
name: 'view',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: 'View',
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
disabled: false,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
items: viewMenuConfig,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
},
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
]
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
export interface EditorMenuItemConfig {
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: string,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcut: string,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
shortcutLabel: React.ReactNode | string,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
callback: any, // I don't understand how to make this a more specific type
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
}
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
export interface EditorMenuConfig {
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
name: string,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
label: string,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
disabled: boolean,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
items: Array<EditorMenuItemConfig>,
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
}
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
function CmdOrCtrl() {
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
return /(Mac|iPhone|iPod|iPad)/i.test(navigator.platform) ? (
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
<Svg
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
name="mac-cmd-key"
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
className="h-3 w-3 inline-block text-left"
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
/>
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
) : (
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
<span>'Ctrl'</span>
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
)
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!
}
Irev-Dev commented 2021-09-08 10:35:59 +02:00 (Migrated from github.com)
Review

if you make this:

const fileMenuConfig: EditorMenuConfig = {

Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since component doesn't exist on EditorMenuItemConfig.

if you make this: ```suggestion const fileMenuConfig: EditorMenuConfig = { ``` Thdn the linter (assuming you've got ts setup with your editor) should tell you if your obeying your own types for this menu, and I think you're not since `component` doesn't exist on `EditorMenuItemConfig`.
Irev-Dev commented 2021-09-08 10:38:23 +02:00 (Migrated from github.com)
Review

I think callback is not needed now and component is?

I think callback is not needed now and component is?
franknoirot commented 2021-09-08 16:00:31 +02:00 (Migrated from github.com)
Review

Yup it yelled at me now!

Yup it yelled at me now!

File diff suppressed because it is too large Load Diff