h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

parse as number even for text if numeric string #452

Merged
hrgdavor merged 1 commits from fis-jscad-params-text into main 2021-08-14 07:51:53 +02:00
Conversation 1 Commits 1 Files Changed 1 +4 -2
hrgdavor commented 2021-08-13 22:46:45 +02:00 (Migrated from github.com)
Copy Link

Sometimes a default type for parameter is textual, but code expects number.

This breaks calls to jscad built-in functions in horrible ways as calculations with a string generate NaN.

It is less of a problem if code expects text (much less the case) and gets number.

Sometimes a default type for parameter is textual, but code expects number. This breaks calls to jscad built-in functions in horrible ways as calculations with a string generate NaN. It is less of a problem if code expects text (much less the case) and gets number.
Irev-Dev (Migrated from github.com) approved these changes 2021-08-14 07:51:48 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#452
Delete Branch "fis-jscad-params-text"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?