h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Tweak heading to better match Figma designs #42

Merged
Irev-Dev merged 1 commits from pr39 into main 2020-10-27 19:47:33 +01:00
Conversation 3 Commits 1 Files Changed 6 +31 -205
Irev-Dev commented 2020-10-27 19:41:55 +01:00 (Migrated from github.com)
Copy Link

Few tweaks on top of @yencolon excellent #39 PR

Few tweaks on top of @yencolon excellent #39 PR
🎉 1
Irev-Dev (Migrated from github.com) reviewed 2020-10-27 19:44:12 +01:00
web/src/layouts/MainLayout/MainLayout.js
@@ -28,3 +27,4 @@
<div className="text-pink-400 text-sm font-bold font-ropa-sans" style={{paddingBottom: '2rem', marginLeft: '-1.8rem'}}>pre-alpha</div>
</div>
</Tooltip>
</li>
Irev-Dev (Migrated from github.com) commented 2020-10-27 19:44:12 +01:00
Copy Link

Added a inline style tags. Because of how specific these styles are to this heading/logo and it doesn't need to be replicated else where as well as it's very precise with the placement of "pre-alpha" I think it's appropiate.

Added a inline style tags. Because of how specific these styles are to this heading/logo and it doesn't need to be replicated else where as well as it's very precise with the placement of "pre-alpha" I think it's appropiate.
yencolon (Migrated from github.com) reviewed 2020-10-27 21:50:56 +01:00
web/src/layouts/MainLayout/MainLayout.js
@@ -28,3 +27,4 @@
<div className="text-pink-400 text-sm font-bold font-ropa-sans" style={{paddingBottom: '2rem', marginLeft: '-1.8rem'}}>pre-alpha</div>
</div>
</Tooltip>
</li>
yencolon (Migrated from github.com) commented 2020-10-27 21:50:56 +01:00
Copy Link

Nice job, I was confused about if I could used other way to style than tailwind

Nice job, I was confused about if I could used other way to style than tailwind
Irev-Dev (Migrated from github.com) reviewed 2020-10-27 21:52:41 +01:00
web/src/layouts/MainLayout/MainLayout.js
@@ -28,3 +27,4 @@
<div className="text-pink-400 text-sm font-bold font-ropa-sans" style={{paddingBottom: '2rem', marginLeft: '-1.8rem'}}>pre-alpha</div>
</div>
</Tooltip>
</li>
Irev-Dev (Migrated from github.com) commented 2020-10-27 21:52:41 +01:00
Copy Link

Sorry, I could have made that clearer.

Sorry, I could have made that clearer.
Sign in to join this conversation.
Reviewers
No Reviewers
yencolon
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#42
Delete Branch "pr39"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?