h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Gzip files before upload to s3 + high quality CadQuery downloads + TS conversions #396

Merged
Irev-Dev merged 2 commits from kurt/gzip-391 into main 2021-07-04 12:49:21 +02:00
Conversation 0 Commits 2 Files Changed 15 +175 -65
Irev-Dev commented 2021-07-03 05:32:13 +02:00 (Migrated from github.com)
Copy Link

So I was trying to Gzip files before they're uploaded to s3,

But also got side tracked in extending work that had partially been done for #381, in that now the preview STLs from CadQuery are at one quality, and downloads a higher quality. In the process I I wanted to improve some of the files I was working in by converting to typescript, but typescript has a way of spreading, converting one file triggers more to be converted not a bad thing really.

Anyway the Gziping looks good, getting about a 10x reduction in file size.

Resolves #381 and #391

  • Don't merge until the AWS/serverless stack has been redeployed.
So I was trying to Gzip files before they're uploaded to s3, But also got side tracked in extending work that had partially been done for #381, in that now the preview STLs from CadQuery are at one quality, and downloads a higher quality. In the process I I wanted to improve some of the files I was working in by converting to typescript, but typescript has a way of spreading, converting one file triggers more to be converted not a bad thing really. Anyway the Gziping looks good, getting about a 10x reduction in file size. Resolves #381 and #391 - [x] Don't merge until the AWS/serverless stack has been redeployed.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#396
Delete Branch "kurt/gzip-391"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?