h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Make sure the code-init is robust when local storage is empty #333

Merged
Irev-Dev merged 1 commits from kurt/fix-init-code-bug into main 2021-05-30 06:01:52 +02:00
Conversation 0 Commits 1 Files Changed 4 +14 -10
Irev-Dev commented 2021-05-30 06:01:45 +02:00 (Migrated from github.com)
Copy Link

We put draft code into local storage so user's don't lose their code if they click away in draft, but because of this a bug had creeped in that would cause error if it was the user's first time on the site, I need to remember to clear my local storage when doing regression testing.

Even though it was local storage that cause the bug, this code wasn't working either, even since we introduced CadQuery because it needs to deal with two cade package which it wasn't doing so that's fixed too now.

We put draft code into local storage so user's don't lose their code if they click away in draft, but because of this a bug had creeped in that would cause error if it was the user's first time on the site, I need to remember to clear my local storage when doing regression testing. Even though it was local storage that cause the bug, this code wasn't working either, even since we introduced CadQuery because it needs to deal with two cade package which it wasn't doing so that's fixed too now.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#333
Delete Branch "kurt/fix-init-code-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?