h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Added initial Monaco Editor to dev-ide, made console pane scrollable #233

Merged
franknoirot merged 3 commits from franknoirot/218 into main 2021-03-10 10:19:26 +01:00
Conversation 3 Commits 3 Files Changed 6 +42 -21
franknoirot commented 2021-03-10 07:08:17 +01:00 (Migrated from github.com)
Copy Link

Initial addition of the Monaco editor, no theming or anything, and moving the Render button up into the toolbar.

I may have to undo my scrollable console pane in an upcoming PR, because I think the console should autoscroll on new messages, and doing that requires useRef and useEffect within IdeConsole to scroll to the bottom with JS, but the element that I've made scrollable right now is .mosaic-window-body, which is created by the layout manager so I don't think I can get a ref to it.

Initial addition of the Monaco editor, no theming or anything, and moving the Render button up into the toolbar. I may have to undo my scrollable console pane in an upcoming PR, because I think the console should autoscroll on new messages, and doing that requires `useRef` and `useEffect` within `IdeConsole` to scroll to the bottom with JS, but the element that I've made scrollable right now is `.mosaic-window-body`, which is created by the layout manager so I don't think I can get a ref to it.
Irev-Dev (Migrated from github.com) approved these changes 2021-03-10 10:19:16 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Nice, I pushed one commit of my own of what I'm 99% sure was a error in 2b87d6a

Let me know if I'm mistaken.

Nice, I pushed one commit of my own of what I'm 99% sure was a error in 2b87d6a Let me know if I'm mistaken.
franknoirot commented 2021-03-10 18:07:32 +01:00 (Migrated from github.com)
Copy Link

Nice, I pushed one commit of my own of what I'm 99% sure was a error in 2b87d6a

Let me know if I'm mistaken.

You are 100% correct, thank you. I was being suplexed by Git all day yesterday: no joke I redid the edits in this PR 4 separate times. I should've just slept on it but I swore I would get something submitted lol

> > > Nice, I pushed one commit of my own of what I'm 99% sure was a error in [2b87d6a](https://github.com/Irev-Dev/cadhub/commit/2b87d6a47411bd20b8feec693e0ddb49dbeccfcb) > > Let me know if I'm mistaken. You are 100% correct, thank you. I was being suplexed by Git all day yesterday: no joke I redid the edits in this PR 4 separate times. I should've just slept on it but I swore I would get something submitted lol
😕 1
Irev-Dev commented 2021-03-10 22:43:18 +01:00 (Migrated from github.com)
Copy Link

I was being suplexed by Git all day yesterday: no joke I redid the edits in this PR 4 separate times. I should've just slept on it but I swore I would get something submitted lol

Ugh, that sucks. Let me know if I can help.

> I was being suplexed by Git all day yesterday: no joke I redid the edits in this PR 4 separate times. I should've just slept on it but I swore I would get something submitted lol Ugh, that sucks. Let me know if I can help.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#233
Delete Branch "franknoirot/218"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?