Added react-mosaic-component layout manager to IdeContainer #229

2021-03-09T06:59:10+01:00

franknoirot commented

2021-03-09 06:59:10 +01:00

(Migrated from github.com)

I actually really prefer this package to react-grid-layout, because it is far more lightweight and it's drag-and-drop behavior works as I would intuitively expect it to, where items resize to fit the available space given a dragged item's new dimensions.

Another cool feature of this library is that we have the option to add toolbars for each window pane with their custom logic and styling. So we can easily do the color coding we discussed for different CAD packages, and could even move the toolbar buttons into these panes if we wanted (render into the viewer, save into the editor, etc), or just provide a configuration "gear icon" button that lets the user set their preferences for each pane.

Apologies my linting doesn't seem to be working quite right, so this will cause some whitespace commit diffs in future. I'll try to sort it out before doing larger work.

I actually really prefer this package to `react-grid-layout`, because it is far more lightweight and it's drag-and-drop behavior works as I would intuitively expect it to, where items resize to fit the available space given a dragged item's new dimensions. Another cool feature of this library is that we have the option to add toolbars for _each window pane_ with their custom logic and styling. So we can easily do the color coding we discussed for different CAD packages, and could even move the toolbar buttons into these panes if we wanted (render into the viewer, save into the editor, etc), or just provide a configuration "gear icon" button that lets the user set their preferences for each pane. Apologies my linting doesn't seem to be working quite right, so this will cause some whitespace commit diffs in future. I'll try to sort it out before doing larger work.

Irev-Dev (Migrated from github.com) reviewed 2021-03-09 06:59:10 +01:00

franknoirot commented

2021-03-09 07:00:38 +01:00

(Migrated from github.com)

Good lord my linter nonsense got commited. I'm gonna delete this and redo, apologies.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/cadhub#229