h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Showing state being passed into useIdeState dispatch middleware #224

Merged
franknoirot merged 2 commits from franknoirot/218 into main 2021-03-05 07:29:43 +01:00
Conversation 5 Commits 2 Files Changed 6 +71 -9
franknoirot commented 2021-03-05 05:20:52 +01:00 (Migrated from github.com)
Copy Link

I also made some minor tweaks, moved that new openSCAD controller into a cadPackages subdirectory and duplicated it to make a faux openCascade controller as well, so that by switching between them you can see the objectData type changes between stl and jpg.

I also made some minor tweaks, moved that new openSCAD controller into a `cadPackages` subdirectory and duplicated it to make a faux openCascade controller as well, so that by switching between them you can see the `objectData` type changes between `stl` and `jpg`.
franknoirot commented 2021-03-05 05:26:40 +01:00 (Migrated from github.com)
Copy Link

Aw what the heck I think my commits are still weird and anonymous. Give me my sticker Github! haha

Aw what the heck I think my commits are still weird and anonymous. Give me my sticker Github! haha
😕 1
franknoirot commented 2021-03-05 05:32:15 +01:00 (Migrated from github.com)
Copy Link

Ugh I figured it out 🤦🏻‍♂️ my local git config email doesn't match my Github profile one. Fixing.

Ugh I figured it out 🤦🏻‍♂️ my local git config email doesn't match my Github profile one. Fixing.
🚀 1
franknoirot commented 2021-03-05 05:34:52 +01:00 (Migrated from github.com)
Copy Link

Sweet there we go, proper commit!

Sweet there we go, proper commit!
Irev-Dev (Migrated from github.com) approved these changes 2021-03-05 07:29:05 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Nice,
Super motivated to finish getting what I've got so of the openScad API deployed so we can start getting more of this working.

Nice, Super motivated to finish getting what I've got so of the openScad API deployed so we can start getting more of this working.
web/src/helpers/hooks/useIdeState.js
Irev-Dev (Migrated from github.com) commented 2021-03-05 07:27:06 +01:00
Copy Link

It seems obvious in retrospect, but I'm really glad you thought of this.

It seems obvious in retrospect, but I'm really glad you thought of this.
web/src/helpers/hooks/useIdeState.js
Irev-Dev (Migrated from github.com) commented 2021-03-05 07:26:29 +01:00
Copy Link

🚀

🚀
franknoirot (Migrated from github.com) reviewed 2021-03-05 07:40:23 +01:00
web/src/helpers/hooks/useIdeState.js
franknoirot (Migrated from github.com) commented 2021-03-05 07:40:23 +01:00
Copy Link

I'm gonna have to remember this for future projects, it seems like a muscular little pattern.

I'm gonna have to remember this for future projects, it seems like a muscular little pattern.
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
franknoirot
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#224
Delete Branch "franknoirot/218"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?