h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

feat: Seo improvement #113

Merged
matheusdoedev merged 7 commits from dev into main 2020-11-18 21:07:31 +01:00
Conversation 5 Commits 7 Files Changed 28 -1
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c29c19b890 - Show all commits

1
web/src/components/Seo/Seo.js
View File

@@ -1,4 +1,3 @@
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review
Copy Link

right, I will remove

right, I will remove
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review
Copy Link

right, I will remove

right, I will remove
import React from 'react'
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review
Copy Link

right, I will remove

right, I will remove
import { Helmet } from 'react-helmet'
const Seo = ({ title, description, lang }) => {
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review
Copy Link

right, I will remove

right, I will remove
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review
Copy Link

right, I will remove

right, I will remove