h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

feat: Seo improvement #113

Merged
matheusdoedev merged 7 commits from dev into main 2020-11-18 21:07:31 +01:00
Conversation 5 Commits 7 Files Changed 28 +136 -3
matheusdoedev commented 2020-11-18 18:45:53 +01:00 (Migrated from github.com)
Copy Link

Changes:

  • react helmet,
  • seo component,
  • seo on all pages,
  • seo dynamic on parts and users pages

Issues

  • #102 Add React Helmet
Changes: - react helmet, - seo component, - seo on all pages, - seo dynamic on parts and users pages Issues - #102 Add React Helmet
Irev-Dev (Migrated from github.com) requested changes 2020-11-18 19:04:06 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Nice, thanks @Matheusdoe-dev.

I've asked for some small changes (basically can you remove two lines).

Nice, thanks @Matheusdoe-dev. I've asked for some small changes (basically can you remove two lines).
web/src/components/Seo/Seo.js
Irev-Dev (Migrated from github.com) commented 2020-11-18 19:02:37 +01:00
Copy Link

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
web/src/index.html
Irev-Dev (Migrated from github.com) commented 2020-11-18 19:01:01 +01:00
Copy Link

I don't think this should be here as the favicon is set as a webpack plugin.
https://github.com/Irev-Dev/cadhub/blob/main/web/config/webpack.config.js
Could we remove it?

I don't think this <link> should be here as the favicon is set as a webpack plugin. https://github.com/Irev-Dev/cadhub/blob/main/web/config/webpack.config.js Could we remove it?
matheusdoedev (Migrated from github.com) reviewed 2020-11-18 20:15:43 +01:00
web/src/components/Seo/Seo.js
matheusdoedev (Migrated from github.com) commented 2020-11-18 20:15:43 +01:00
Copy Link

right, I will remove

right, I will remove
matheusdoedev (Migrated from github.com) reviewed 2020-11-18 20:17:54 +01:00
web/src/index.html
matheusdoedev (Migrated from github.com) commented 2020-11-18 20:17:54 +01:00
Copy Link

right, I will remove this line

right, I will remove this line
matheusdoedev commented 2020-11-18 20:24:48 +01:00 (Migrated from github.com)
Copy Link

The changes are did

The changes are did
🚀 1
Irev-Dev (Migrated from github.com) approved these changes 2020-11-18 21:07:21 +01:00
Irev-Dev (Migrated from github.com) left a comment
Copy Link

Thanks again @Matheusdoe-dev 🚀

Thanks again @Matheusdoe-dev 🚀
Sign in to join this conversation.
Reviewers
No Reviewers
matheusdoedev
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#113
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?