feat: Seo improvement #113

Merged
matheusdoedev merged 7 commits from dev into main 2020-11-18 21:07:31 +01:00
2 changed files with 4 additions and 6 deletions
Showing only changes of commit 374984a01c - Show all commits

View File

@@ -14,13 +14,9 @@ const Seo = ({ title, description, lang }) => {
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
<meta property="og:locale" content={lang} />
<meta property="og:title" content={title} />
<meta property="og:description" content={description} />
<meta property="og:type" content="website" />
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
<meta name="robots" content="index, follow" />
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
<meta name="description" content={description} />
<meta name="keywords" content="cadhub, app, application, web application, cad, code, code-cad, cad-modeling, community, website, cascade studio, openscad" />
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
<title>Cadhub - {title}</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
</Helmet>
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
</Helmet>
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
</>
)
}
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
Irev-Dev commented 2020-11-18 19:02:37 +01:00 (Migrated from github.com)
Review

Could we remove this react import, please?

The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.

Could we remove this react import, please? The redwood framework does some magic to add react without explicitly importing it. and why there's nothing wrong with importing it anyway, it makes it inconsistent with the rest of the react components.
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove
matheusdoedev commented 2020-11-18 20:15:43 +01:00 (Migrated from github.com)
Review

right, I will remove

right, I will remove

View File

@@ -3,7 +3,9 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<meta name="keywords" content="cadhub, app, application, web application, cad, code, code-cad, cad-modeling, community, website, cascade studio, openscad" />
<meta property="og:type" content="website" />
<meta name="robots" content="index, follow" />
<link rel="icon" type="image/png" href="/favi2.jpg" />
<title><%= htmlWebpackPlugin.options.title %></title>