h3n3/cadhub
1
0
Fork 0
Code Issues 35 Pull Requests Packages Projects Releases Wiki Activity

Add zoom to fit on first load #561

Merged
lejara merged 2 commits from zoomToFit into main 2021-10-16 20:40:58 +02:00
Conversation 3 Commits 2 Files Changed 1 +64 -23
lejara commented 2021-10-16 18:05:37 +02:00 (Migrated from github.com)
Copy Link

Resolves: #555

Since the Asset component only runs on meshes. There's no need to code an edge case for png openSCAD projects

You can adjust the camera-to-object distance by changing the offset var

Resolves: #555 Since the `Asset` component only runs on meshes. There's no need to code an edge case for png openSCAD projects You can adjust the camera-to-object distance by changing the `offset` var
Irev-Dev (Migrated from github.com) approved these changes 2021-10-16 20:39:38 +02:00
app/web/src/components/IdeViewer/IdeViewer.tsx
@@ -25,3 +35,3 @@
() =>
incomingGeo.length
incomingGeo.length || dataType !== 'geometry'
? null
Irev-Dev (Migrated from github.com) commented 2021-10-16 20:38:14 +02:00
Copy Link

Nice catch!

Nice catch!
app/web/src/components/IdeViewer/IdeViewer.tsx
Irev-Dev (Migrated from github.com) commented 2021-10-16 20:38:32 +02:00
Copy Link

Perfect 🙌

Perfect 🙌
Irev-Dev commented 2021-10-16 20:40:46 +02:00 (Migrated from github.com)
Copy Link

Nice job and thanks @lejara
Deploying now!

Nice job and thanks @lejara Deploying now!
🎉 1
Irev-Dev commented 2021-10-16 22:19:47 +02:00 (Migrated from github.com)
Copy Link

Live now!

This is a good example of a part that used to get cut off but doesn't anymore
https://cadhub.xyz/u/matiasmiche/jscad-oil-pumpjack

Hey @lejara, I really appreciate the PR.
If you're interested I can send you a CadHub sticker?
sticker

If you'd like one just send me your address to k.hutten@protonmail.ch or dm me on twitter or discord and I'll make it happen 😁

Live now! This is a good example of a part that used to get cut off but doesn't anymore https://cadhub.xyz/u/matiasmiche/jscad-oil-pumpjack Hey @lejara, I really appreciate the PR. If you're interested I can send you a CadHub sticker? ![sticker](https://user-images.githubusercontent.com/29681384/137601148-5bcc8814-3209-410f-9ae3-4f9f1b50d000.jpg) If you'd like one just send me your address to k.hutten@protonmail.ch or dm me on twitter or discord and I'll make it happen 😁
Sign in to join this conversation.
Reviewers
No Reviewers
Irev-Dev
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/cadhub#561
Delete Branch "zoomToFit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?