some more cleanup

apps/nspanel-lovelace-ui/nspanel-lovelace-ui.py

@@ -190,9 +190,9 @@ class LovelaceUIPanel:
         self.generate_entities_page(items)
         # send detail pages in case they are open
         if(entity.startswith("cover")):
-          self.generate_detail_page("popupShutter", entity)
+          self.generate_shutter_detail_page(entity)
         if(entity.startswith("light")):
-          self.generate_detail_page("popupLight", entity)
+          self.generate_light_detail_page(entity)
       return
     
     if page_type in ["cardThermo", "cardMedia"]:
@@ -283,7 +283,10 @@ class LovelaceUIPanel:
 
       if msg[1] == "pageOpenDetail":
         self.api.log("Received pageOpenDetail command", level="DEBUG")
-        self.generate_detail_page(msg[2], msg[3])
+        if msg[2] == "popupShutter":
+          self.generate_shutter_detail_page(msg[3])
+        if msg[2] == "popupLight":
+          self.generate_light_detail_page(msg[3])
 
       if msg[1] == "tempUpd":
         self.api.log("Received tempUpd command", level="DEBUG")
@@ -632,14 +635,10 @@ class LovelaceUIPanel:
       icon_color = rgb_dec565(color)
     return icon_color
 
-
-  def generate_detail_page(self, page_type, entity):
-    if page_type == "popupLight":
+  def generate_light_detail_page(self, entity):
     entity = self.api.get_entity(entity)
     switch_val = 1 if entity.state == "on" else 0
-
     icon_color = self.getEntityColor(entity)
-
     brightness = "disable"
     color_temp = "disable"
     color = "disable"
@@ -665,7 +664,8 @@ class LovelaceUIPanel:
         color = "disable"
     self.send_mqtt_msg(f"entityUpdateDetail,{get_icon_id('lightbulb')},{icon_color},{switch_val},{brightness},{color_temp},{color}")
 
-    if page_type == "popupShutter":
+
+  def generate_shutter_detail_page(self, entity):
     pos = self.api.get_entity(entity).attributes.current_position
     # reverse position for slider
     pos = 100-pos