h3n3/klipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sos_filter: Fix validate_section_index() check

Browse Source 
A section_idx equal to max_sections is also invalid.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor
2025-06-11 17:59:02 -04:00
parent 5666b88c69
commit f54b7b9376
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sos_filter.c
View File

@@ -108,7 +108,7 @@ sos_filter_oid_lookup(uint8_t oid)
static void static void
validate_section_index(struct sos_filter *sf, uint8_t section_idx) validate_section_index(struct sos_filter *sf, uint8_t section_idx)
{ {
if (section_idx > sf->max_sections) if (section_idx >= sf->max_sections)
shutdown("Filter section index larger than max_sections"); shutdown("Filter section index larger than max_sections");
} }
@@ -154,7 +154,8 @@ command_sos_filter_activate(uint32_t *args)
{ {
struct sos_filter *sf = sos_filter_oid_lookup(args[0]); struct sos_filter *sf = sos_filter_oid_lookup(args[0]);
uint8_t n_sections = args[1]; uint8_t n_sections = args[1];
validate_section_index(sf, n_sections); if (n_sections > sf->max_sections)
shutdown("Filter section index larger than max_sections");
sf->n_sections = n_sections; sf->n_sections = n_sections;
const uint8_t coeff_int_bits = args[2]; const uint8_t coeff_int_bits = args[2];
sf->coeff_frac_bits = (31 - coeff_int_bits); sf->coeff_frac_bits = (31 - coeff_int_bits);