h3n3/klipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

i2ccmds: Pass the i2c address as a 7-bit number (0-127)

Browse Source 
The sam3 i2c code and the linux code use a 7-bit i2c address, while
the avr, lpc176x, and samd21 i2c code uses an 8-bit address with the
least significant bit always zero.  A similar issue occurred in the
host code (sx1509.py and replicape.py use 7-bit addresses while
uc1701.py and mcp4451.py use 8-bit addresses).

Consistently use 7-bit addresses in all the code.  This breaks
compatibility between host and mcu software, so make a change to the
config_i2c command to force users to synchronize software updates.
This also breaks common Smoothieboard configs, so update the mcp4451
code to validate the i2c_address.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor
2018-12-27 19:11:46 -05:00
committed by KevinOConnor
parent f2f54290e8
commit e26d1a3567
10 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/i2ccmds.c
View File

@@ -16,15 +16,13 @@ struct i2cdev_s {
void
command_config_i2c(uint32_t *args)
{
uint8_t addr = args[3];
if (addr & 1)
shutdown("Invalid I2C address");
uint8_t addr = args[3] & 0x7f;
struct i2cdev_s *i2c = oid_alloc(args[0], command_config_i2c
, sizeof(*i2c));
i2c->i2c_config = i2c_setup(args[1], args[2], addr);
}
DECL_COMMAND(command_config_i2c,
"config_i2c oid=%c bus=%u rate=%u addr=%u");
"config_i2c oid=%c bus=%u rate=%u address=%u");
void
command_i2c_write(uint32_t *args)