h3n3/klipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

irq: Prefer irq_disable/enable instead of irq_save/restore in cmds/tasks

Browse Source 
Task and command handlers always run with irqs enabled, so it is not
necessary to save/restore the irq state when disabling irqs in these
handlers.

Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
Kevin O'Connor
2016-06-08 20:51:00 -04:00
parent 4fcf5a31f5
commit 9dd101c26f
4 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/gpiocmds.c
View File

@@ -6,7 +6,7 @@
#include "basecmd.h" // alloc_oid
#include "board/gpio.h" // struct gpio_out
#include "board/irq.h" // irq_save
#include "board/irq.h" // irq_disable
#include "command.h" // DECL_COMMAND
#include "sched.h" // sched_timer
@@ -188,7 +188,7 @@ command_schedule_soft_pwm_out(uint32_t *args)
if (s->max_duration)
next_flags |= SPF_NEXT_CHECK_END;
}
uint8_t flag = irq_save();
irq_disable();
if (s->flags & SPF_CHECK_END && sched_is_before(s->end_time, time))
shutdown("next soft pwm extends existing pwm");
s->end_time = time;
@@ -204,7 +204,7 @@ command_schedule_soft_pwm_out(uint32_t *args)
s->timer.func = soft_pwm_load_event;
sched_timer(&s->timer);
}
irq_restore(flag);
irq_enable();
}
DECL_COMMAND(command_schedule_soft_pwm_out,
"schedule_soft_pwm_out oid=%c clock=%u value=%c");