pins: Explicitly pass can_invert and can_pullup to lookup_pin()
Don't pass pin_type to lookup_pin() - instead, if a pin can be inverted or can have a pullup, then the caller must explicitly specify that when calling lookup_pin(). This simplifies the code for the cases where it is not valid to invert or pullup. Explicitly pass the pin_type to setup_pin() and have ppins.setup_pin() apply default pullup and invert flags. Signed-off-by: Kevin O'Connor <kevin@koconnor.net>
This commit is contained in:
@@ -610,10 +610,9 @@ class MCU:
|
||||
self.register_msg(self._handle_mcu_stats, 'stats')
|
||||
self._check_config()
|
||||
# Config creation helpers
|
||||
def setup_pin(self, pin_params):
|
||||
def setup_pin(self, pin_type, pin_params):
|
||||
pcs = {'stepper': MCU_stepper, 'endstop': MCU_endstop,
|
||||
'digital_out': MCU_digital_out, 'pwm': MCU_pwm, 'adc': MCU_adc}
|
||||
pin_type = pin_params['type']
|
||||
if pin_type not in pcs:
|
||||
raise pins.error("pin type %s not supported on mcu" % (pin_type,))
|
||||
co = pcs[pin_type](self, pin_params)
|
||||
|
||||
Reference in New Issue
Block a user