feat: add OctoApp support #454

Merged
crysxd merged 6 commits from master into master 2024-03-31 17:15:47 +02:00
7 changed files with 394 additions and 6 deletions

View File

@@ -154,18 +154,20 @@ prompt and confirm by hitting ENTER.
<tr>
<th><h3><a href="https://github.com/Clon1998/mobileraker_companion">Mobileraker's Companion</a></h3></th>
<th><h3><a href="https://octoeverywhere.com/?source=kiauh_readme">OctoEverywhere For Klipper</a></h3></th>
<th><h3><a href="https://github.com/crysxd/OctoPrint-OctoApp">OctoApp For Klipper</a></h3></th>
<th><h3></h3></th>
</tr>
<tr>
<th><a href="https://github.com/Clon1998/mobileraker_companion"><img src="https://raw.githubusercontent.com/Clon1998/mobileraker/master/assets/icon/mr_appicon.png" alt="OctoEverywhere Logo" height="64"></th>
<th><a href="https://octoeverywhere.com/?source=kiauh_readme"><img src="https://octoeverywhere.com/img/logo.svg" alt="OctoEverywhere Logo" height="64"></a></th>
<th></th>
<th><a href="https://octoapp.eu/?source=kiauh_readme"><img src="https://octoapp.eu/octoapp.webp" alt="OctoApp Logo" height="64"></a></th>
</tr>
<tr>
<th>by <a href="https://github.com/Clon1998">Patrick Schmidt</a></th>
<th>by <a href="https://github.com/QuinnDamerell">Quinn Damerell</a></th>
<th>by <a href="https://github.com/crysxd">Christian Würthner</a></th>
<th></th>
</tr>

View File

@@ -83,4 +83,8 @@ function set_globals() {
MOBILERAKER_DIR="${HOME}/mobileraker_companion"
MOBILERAKER_REPO="https://github.com/Clon1998/mobileraker_companion.git"
#=============== OCTOAPP ================#
OCTOAPP_ENV="${HOME}/octoapp-env"
OCTOAPP_DIR="${HOME}/octoapp"
OCTOAPP_REPO="https://github.com/crysxd/OctoApp-Plugin.git"
}

369
scripts/octoapp.sh Normal file
View File

@@ -0,0 +1,369 @@
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#!/usr/bin/env bash
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#=======================================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Copyright (C) 2020 - 2024 Dominik Willner <th33xitus@gmail.com> #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# This file is part of KIAUH - Klipper Installation And Update Helper #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# https://github.com/dw-0/kiauh #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# This file may be distributed under the terms of the GNU GPLv3 license #
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#=======================================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# This file is written and maintained by Christian Würthner from OctoApp
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Please contact me if you need any help!
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# hello@octoapp.eu
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
set -e
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#============== Install ============#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function octoapp_systemd() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local services
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
services=$(find "${SYSTEMD}" -maxdepth 1 -regextype posix-extended -regex "${SYSTEMD}/octoapp(-[0-9a-zA-Z]+)?.service")
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${services}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function octoapp_setup_dialog() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Initializing OctoApp for Klipper installation ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# First, check for moonraker service instances.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local moonraker_count
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local moonraker_names
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
moonraker_count=$(moonraker_systemd | wc -w)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( moonraker_count == 0 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### return early if moonraker is not installed
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local error="Moonraker not installed! Please install Moonraker first!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
log_error "OctoApp setup started without Moonraker being installed. Aborting setup."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
print_error "${error}" && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
elif (( moonraker_count > 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# moonraker_names is valid only in case of multi-instance
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
read -r -a moonraker_names <<< "$(get_multi_instance_names)"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Next, check for any existing OctoApp services.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local octoapp_services
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local existing_octoapp_count
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
octoapp_services=$(octoapp_systemd)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
existing_octoapp_count=$(echo "${octoapp_services}" | wc -w )
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# We need to make the moonraker instance count to the OctoApp service count.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local allowed_octoapp_count=$(( moonraker_count - existing_octoapp_count ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( allowed_octoapp_count > 0 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local new_octoapp_count
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### Step 1: Ask for the number of OctoApp instances to install
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( moonraker_count == 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "Moonraker installation found!\n"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
new_octoapp_count=1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
elif (( moonraker_count > 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
top_border
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
printf "|${green}%-55s${white}|\n" " ${moonraker_count} Moonraker instances found!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for name in "${moonraker_names[@]}"; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
printf "|${cyan}%-57s${white}|\n" " ● moonraker-${name}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
blank_line
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( existing_octoapp_count > 0 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
printf "|${green}%-55s${white}|\n" " ${existing_octoapp_count} OctoApp instances already installed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for svc in ${octoapp_services}; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
printf "|${cyan}%-57s${white}|\n" " ● octoapp-$(get_instance_name "${svc}")"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
blank_line
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| The setup will apply the same names to OctoApp |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
blank_line
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| Please select the number of OctoApp instances to |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| install. Usually one OctoApp instance per Moonraker |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| instance is required, but you may not install more |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| OctoApp instances than available Moonraker instances. |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
bottom_border
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### ask for amount of instances
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local re="^[1-9][0-9]*$"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
while [[ ! ${new_octoapp_count} =~ ${re} || ${new_octoapp_count} -gt ${allowed_octoapp_count} ]]; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
read -p "${cyan}###### Number of new OctoApp instances to set up:${white} " -i "${allowed_octoapp_count}" -e new_octoapp_count
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### break if input is valid
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ${new_octoapp_count} =~ ${re} && ${new_octoapp_count} -le ${allowed_octoapp_count} ]] && break
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### conditional error messages
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ! ${new_octoapp_count} =~ ${re} ]] && error_msg "Input not a number"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
(( new_octoapp_count > allowed_octoapp_count )) && error_msg "Number of OctoApp instances larger than installed Moonraker instances"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done && select_msg "${new_octoapp_count}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
else
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
log_error "Internal error. moonraker_count of '${moonraker_count}' not equal or grater than one!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
return 1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi # (( moonraker_count == 1 ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi # (( allowed_octoapp_count > 0 ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Special case for one moonraker instance with OctoApp already installed.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# If the user selects the install option again, they might be trying to recover the install
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# or complete a printer link they didn't finish in the past.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# So in this case, we will allow them to run the install script again, since it's safe to run
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# if the service is already installed, it will repair any missing issues.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( allowed_octoapp_count == 0 && moonraker_count == 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local yn
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
while true; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${yellow}OctoApp is already installed.${white}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "It is safe to run the install again to repair any issues or if the printer isn't linked, run the printer linking logic again."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo ""
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local question="Do you want to run the OctoApp recovery or linking logic again?"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
read -p "${cyan}###### ${question} (Y/n):${white} " yn
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
case "${yn}" in
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
Y|y|Yes|yes|"")
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
select_msg "Yes"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
break;;
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
N|n|No|no)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
select_msg "No"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
abort_msg "Exiting OctoApp setup ...\n"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
return;;
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
*)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
error_msg "Invalid Input!";;
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
esac
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# The user responded yes, allow the install to run again.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
allowed_octoapp_count=1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# If there's something to install, do it!
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( allowed_octoapp_count > 0 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
(( new_octoapp_count > 1 )) && status_msg "Installing ${new_octoapp_count} OctoApp instances ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
(( new_octoapp_count == 1 )) && status_msg "Installing OctoApp ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Ensure the basic system dependencies are installed.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local dep=(git dfu-util virtualenv python3 python3-pip python3-venv)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dependency_check "${dep[@]}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Close the repo
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
clone_octoapp "${OCTOAPP_REPO}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Call install with the correct args.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local instance_cfg_dirs
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
read -r -a instance_cfg_dirs <<< "$(get_instance_folder_path "config")"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo instance_cfg_dirs[0]
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( moonraker_count == 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
"${OCTOAPP_DIR}/install.sh" "${instance_cfg_dirs[0]}/moonraker.conf"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
elif (( moonraker_count > 1 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local j=${existing_octoapp_count}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for (( i=1; i <= new_octoapp_count; i++ )); do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
"${OCTOAPP_DIR}/install.sh" "${instance_cfg_dirs[${j}]}/moonraker.conf"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
j=$(( j + 1 ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done && unset j
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi # (( moonraker_count == 1 ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi # (( allowed_octoapp_count > 0 ))
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function octoapp_install() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
"${OCTOAPP_DIR}/install.sh" "$@"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#============= Remove ==============#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_systemd() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ -z $(octoapp_systemd) ]] && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing OctoApp Systemd Services ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for service in $(octoapp_systemd | cut -d"/" -f5); do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing ${service} ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
sudo systemctl stop "${service}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
sudo systemctl disable "${service}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
sudo rm -f "${SYSTEMD}/${service}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "Done!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### reloading units
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
sudo systemctl daemon-reload
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
sudo systemctl reset-failed
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "OctoApp Services removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_logs() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local files regex="${HOME//\//\\/}\/([A-Za-z0-9_]+)\/logs\/octoapp(-[0-9a-zA-Z]+)?\.log(.*)?"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
files=$(find "${HOME}" -maxdepth 3 -regextype posix-extended -regex "${regex}" | sort)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if [[ -n ${files} ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for file in ${files}; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing ${file} ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
rm -f "${file}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "${file} removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_dir() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ! -d ${OCTOAPP_DIR} ]] && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing OctoApp directory ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
rm -rf "${OCTOAPP_DIR}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "Directory removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_config() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Remove the system config but not the main config, so the printer id doesn't get lost.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local files regex="${HOME//\//\\/}\/([A-Za-z0-9_]+)\/config\/octoapp-system(-[0-9a-zA-Z]+)?\.cfg(.*)?"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
files=$(find "${HOME}" -maxdepth 4 -regextype posix-extended -regex "${regex}" | sort)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if [[ -n ${files} ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for file in ${files}; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing ${file} ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
rm -f "${file}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "${file} removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_store_dir() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local files regex="${HOME//\//\\/}\/([A-Za-z0-9_]+)\/octoapp-store"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
files=$(find "${HOME}" -maxdepth 2 -type d -regextype posix-extended -regex "${regex}" | sort)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if [[ -n ${files} ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
for file in ${files}; do
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing ${file} ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
rm -rf "${file}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "${file} removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp_env() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ! -d "${HOME}/octoapp-env" ]] && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Removing octoapp-env directory ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
rm -rf "${HOME}/octoapp-env"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "Directory removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function remove_octoapp()
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
{
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_systemd
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_logs
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_dir
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_env
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_config
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remove_octoapp_store_dir
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
print_confirm "OctoApp was successfully removed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#============= UPDATE ==============#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function update_octoapp() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
do_action_service "stop" "octoapp"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if [[ ! -d ${OCTOAPP_DIR} ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
clone_octoapp "${OCTOAPP_REPO}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
else
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
backup_before_update "octoapp"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Updating OctoApp for Klipper ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
cd "${OCTOAPP_DIR}" && git pull
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### read PKGLIST and install possible new dependencies
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
install_octoapp_dependencies
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### install possible new python dependencies
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
"${OCTOAPP_ENV}"/bin/pip install -r "${OCTOAPP_DIR}/requirements.txt"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
ok_msg "Update complete!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
do_action_service "restart" "octoapp"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function clone_octoapp() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local repo=${1}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Cloning OctoApp from ${repo} ..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### force remove existing octoapp dir and clone into fresh octoapp dir
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ -d ${OCTOAPP_DIR} ]] && rm -rf "${OCTOAPP_DIR}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
cd "${HOME}" || exit 1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if ! git clone "${OCTOAPP_REPO}" "${OCTOAPP_DIR}"; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
print_error "Cloning OctoApp from\n ${repo}\n failed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
exit 1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function install_octoapp_dependencies() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local packages log_name="OctoApp"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local install_script="${OCTOAPP_DIR}/install.sh"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### read PKGLIST from official install-script
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Reading dependencies..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# shellcheck disable=SC2016
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
packages="$(grep "PKGLIST=" "${install_script}" | cut -d'"' -f2 | sed 's/\${PKGLIST}//g' | tr -d '\n')"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${cyan}${packages}${white}" | tr '[:space:]' '\n'
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
read -r -a packages <<< "${packages}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### Update system package lists if stale
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
update_system_package_lists
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### Install required packages
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
install_system_packages "${log_name}" "packages[@]"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#============= STATUS ==============#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
#===================================================#
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function get_octoapp_status() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local status
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local service_count
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local octoapp_services
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
octoapp_services=$(octoapp_systemd)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
service_count=$(echo "${octoapp_services}" | wc -w )
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if (( service_count == 0 )); then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status="Not installed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
elif [[ ! -d "${OCTOAPP_DIR}" ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status="Incomplete!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
else
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status="Installed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${status}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function get_local_octoapp_commit() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ! -d ${OCTOAPP_DIR} || ! -d "${OCTOAPP_DIR}/.git" ]] && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local commit
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
cd "${OCTOAPP_DIR}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
commit="$(git describe HEAD --always --tags | cut -d "-" -f 1,2)"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${commit}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function get_remote_octoapp_commit() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ ! -d ${OCTOAPP_DIR} || ! -d "${OCTOAPP_DIR}/.git" ]] && return
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local commit
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
cd "${OCTOAPP_DIR}" && git fetch origin -q
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
commit=$(git describe origin/release --always --tags | cut -d "-" -f 1,2)
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${commit}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function compare_octoapp_versions() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local versions local_ver remote_ver
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local_ver="$(get_local_octoapp_commit)"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
remote_ver="$(get_remote_octoapp_commit)"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if [[ ${local_ver} != "${remote_ver}" ]]; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
versions="${yellow}$(printf " %-14s" "${local_ver}")${white}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
# Add us to the update file, so if the user selects "update all" it includes us.
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
add_to_application_updates "octoapp"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
else
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
versions="${green}$(printf " %-14s" "${local_ver}")${white}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo "${versions}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

View File

@@ -28,9 +28,10 @@ function install_ui() {
echo -e "| 4) [Fluidd] | 9) $(obico_install_title) |"
echo -e "| | 10) [OctoEverywhere] |"
echo -e "| | 11) [Mobileraker] |"
echo -e "| Touchscreen GUI: | |"
echo -e "| 5) [KlipperScreen] | Webcam Streamer: |"
echo -e "| | 12) [Crowsnest] |"
echo -e "| Touchscreen GUI: | 12) [OctoApp for Klipper] |"
echo -e "| 5) [KlipperScreen] | |"
echo -e "| | Webcam Streamer: |"
echo -e "| | 13) [Crowsnest] |"
back_footer
}
@@ -72,6 +73,8 @@ function install_menu() {
11)
do_action "install_mobileraker" "install_ui";;
12)
do_action "octoapp_setup_dialog" "install_ui";;
13)
do_action "install_crowsnest" "install_ui";;
B|b)
clear; main_menu; break;;

View File

@@ -28,6 +28,7 @@ function main_ui() {
echo -e "| | Obico: $(print_status "moonraker_obico")|"
echo -e "| | OctoEverywhere: $(print_status "octoeverywhere")|"
echo -e "| | Mobileraker: $(print_status "mobileraker")|"
echo -e "| | OctoApp: $(print_status "octoapp")|"
echo -e "| | |"
echo -e "| | Octoprint: $(print_status "octoprint")|"
hr

View File

@@ -31,6 +31,7 @@ function remove_ui() {
echo -e "| 7) [KlipperScreen] | 14) [OctoEverywhere] |"
echo -e "| | 15) [Mobileraker] |"
echo -e "| | 16) [NGINX] |"
echo -e "| | 17) [OctoApp] |"
back_footer
}
@@ -73,6 +74,8 @@ function remove_menu() {
do_action "remove_mobileraker" "remove_ui";;
16)
do_action "remove_nginx" "remove_ui";;
17)
do_action "remove_octoapp" "remove_ui";;
B|b)
clear; main_menu; break;;
*)

View File

@@ -35,8 +35,9 @@ function update_ui() {
echo -e "| 9) [OctoEverywhere] |$(compare_octoeverywhere_versions)|"
echo -e "| 10) [Mobileraker] |$(compare_mobileraker_versions)|"
echo -e "| 11) [Crowsnest] |$(compare_crowsnest_versions)|"
echo -e "| 12) [OctoApp] |$(compare_octoapp_versions)|"
echo -e "| |------------------------------|"
echo -e "| 12) [System] | $(check_system_updates) |"
echo -e "| 13) [System] | $(check_system_updates) |"
back_footer
}
@@ -73,6 +74,8 @@ function update_menu() {
11)
do_action "update_crowsnest" "update_ui";;
12)
do_action "update_octoapp" "update_ui";;
13)
do_action "upgrade_system_packages" "update_ui";;
a)
do_action "update_all" "update_ui";;
@@ -130,6 +133,9 @@ function update_all() {
[[ "${update_arr[*]}" =~ "mobileraker" ]] && \
echo -e "| ${cyan}● Mobileraker${white} |"
[[ "${update_arr[*]}" =~ "octoapp" ]] && \
echo -e "| ${cyan}● OctoApp${white} |"
[[ "${update_arr[*]}" =~ "system" ]] && \
echo -e "| ${cyan}● System${white} |"