feat: add OctoApp support #454

Merged
crysxd merged 6 commits from master into master 2024-03-31 17:15:47 +02:00
Showing only changes of commit 66cc83a975 - Show all commits

View File

@@ -159,20 +159,6 @@ function octoapp_setup_dialog() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi # (( allowed_octoapp_count > 0 ))
}
function clone_octoapp() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
local repo=${1}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
status_msg "Cloning OctoApp..."
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
### force remove existing repos
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
[[ -d "${OCTOAPP_DIR}" ]] && rm -rf "${OCTOAPP_DIR}"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
cd "${HOME}" || exit 1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
if ! git clone "${repo}" "${OCTOAPP_DIR}"; then
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
print_error "Cloning OctoApp from\n ${repo}\n failed!"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
exit 1
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
fi
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
function octoapp_install() {
"${OCTOAPP_DIR}/install.sh" "$@"
}
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done