h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: add OctoApp support #454

Merged
crysxd merged 6 commits from master into master 2024-03-31 17:15:47 +02:00
Conversation 10 Commits 6 Files Changed 7 +5 -7
1 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4f972bbeae - Show all commits

12
scripts/octoapp.sh
View File

@@ -73,14 +73,12 @@ function octoapp_setup_dialog() {
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
done
fi
blank_line
echo -e "| The setup will apply the same names to |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| OctoApp |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| The setup will apply the same names to OctoApp |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
blank_line
echo -e "| Please select the number of OctoApp instances |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| to install. Usually one OctoApp instance per |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| Moonraker instance is required, but you may not |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| install more OctoApp instances than available |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| Moonraker instances. |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| Please select the number of OctoApp instances to |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| install. Usually one OctoApp instance per Moonraker |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| instance is required, but you may not install more |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
echo -e "| OctoApp instances than available Moonraker instances. |"
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
bottom_border
### ask for amount of instances
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:24:58 +02:00 (Migrated from github.com)
Review
Copy Link
      blank_line
      echo -e "| The setup will apply the same names to OctoApp        |"
      blank_line
      echo -e "| Please select the number of OctoApp instances to      |"
      echo -e "| install. Usually one OctoApp instance per Moonraker   |"
      echo -e "| instance is required, but you may not install more    |"
      echo -e "| OctoApp instances than available Moonraker instances. |"
      bottom_border
```suggestion blank_line echo -e "| The setup will apply the same names to OctoApp |" blank_line echo -e "| Please select the number of OctoApp instances to |" echo -e "| install. Usually one OctoApp instance per Moonraker |" echo -e "| instance is required, but you may not install more |" echo -e "| OctoApp instances than available Moonraker instances. |" bottom_border ```
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
dw-0 commented 2024-03-31 13:27:16 +02:00 (Migrated from github.com)
Review
Copy Link

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.

This function is declared twice in this file. This is coming form the OctoEverywhere script, where this function is also declared twice. We can simply remove that one here.
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done
crysxd commented 2024-03-31 17:08:08 +02:00 (Migrated from github.com)
Review
Copy Link

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done

Removed. I ping Quinn about the duplicate function in OE, but as both are identical there is not much harm done