h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: add Obico for Klipper to KIAUH #227

Merged
kennethjiang merged 36 commits from moonraker_obico into master 2022-08-15 19:44:04 +02:00
Conversation 10 Commits 36 Files Changed 11 +3 -3
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit fa2b728037 - Show all commits

6
scripts/obico.sh
View File

@@ -104,13 +104,13 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
top_border
printf "|${green}%-55s${white}|\n" " ${moonraker_count} Moonraker instances found!"
for name in "${moonraker_names[@]}"; do
printf "|${cyan}%-57s${white}|\n" " ●moonraker-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
printf "|${cyan}%-57s${white}|\n" " ● moonraker-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
done
blank_line
if (( existing_moonraker_obico_count > 0 )); then
printf "|${green}%-55s${white}|\n" " ${existing_moonraker_obico_count} Moonraker-obico instances already installed!"
for name in "${moonraker_obico_names[@]}"; do
printf "|${cyan}%-57s${white}|\n" " ●moonraker-obico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
printf "|${cyan}%-57s${white}|\n" " ● moonraker-obico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
done
fi
blank_line
@@ -219,7 +219,7 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
else
printf "|${green}%-55s${white}|\n" " ${#not_linked_instances[@]} Moonraker-obico instances not linked to the server!"
for name in "${not_linked_instances[@]}"; do
printf "|${cyan}%-57s${white}|\n" " ●moonraker-obico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
printf "|${cyan}%-57s${white}|\n" " ● moonraker-obico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
done
fi
blank_line
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)