feat: add Obico for Klipper to KIAUH #227
@@ -306,3 +306,39 @@ function get_obico_status() {
|
||||
|
|
||||
fi
|
||||
echo "${status}"
|
||||
}
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
function get_local_moonraker_obico_commit() {
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
[[ ! -d ${MOONRAKER_OBICO_DIR} || ! -d "${MOONRAKER_OBICO_DIR}/.git" ]] && return
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
local commit
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
cd "${MOONRAKER_OBICO_DIR}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
commit="$(git describe HEAD --always --tags | cut -d "-" -f 1,2)"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
echo "${commit}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
}
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
function get_remote_moonraker_obico_commit() {
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
[[ ! -d ${MOONRAKER_OBICO_DIR} || ! -d "${MOONRAKER_OBICO_DIR}/.git" ]] && return
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
local commit
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
cd "${MOONRAKER_OBICO_DIR}" && git fetch origin -q
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
commit=$(git describe origin/master --always --tags | cut -d "-" -f 1,2)
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
echo "${commit}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
}
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
function compare_moonraker_obico_versions() {
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
local versions local_ver remote_ver
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
local_ver="$(get_local_moonraker_obico_commit)"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
remote_ver="$(get_remote_moonraker_obico_commit)"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
if [[ ${local_ver} != "${remote_ver}" ]]; then
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
versions="${yellow}$(printf " %-14s" "${local_ver}")${white}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
# add moonraker to application_updates_available in kiauh.ini
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
add_to_application_updates "moonraker_obico"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
else
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
versions="${green}$(printf " %-14s" "${local_ver}")${white}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
versions+="|${green}$(printf " %-13s" "${remote_ver}")${white}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
fi
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
echo "${versions}"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
}
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
This variable seems to be unused?
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using
"${KLIPPER_LOGS}"directly. Feel free to remove it.Another good catch. I guess I planed to use it but ended up using
"${KLIPPER_LOGS}"directly. Feel free to remove it.Can this variable be local? Or is it required to be global? I see it only being used inside the
moonraker_obico_needs_linkingfunctionCan this variable be local? Or is it required to be global? I see it only being used inside the
moonraker_obico_needs_linkingfunctionThis variable seems to be unused now?
This variable seems to be unused now?
See comment above :)
See comment above :)
See comment above :)
See comment above :)