feat: add Obico for Klipper to KIAUH #227

Merged
kennethjiang merged 36 commits from moonraker_obico into master 2022-08-15 19:44:04 +02:00
2 changed files with 17 additions and 8 deletions
Showing only changes of commit db203d0321 - Show all commits

View File

@@ -23,7 +23,7 @@ function moonraker_obico_systemd() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
function cfg_dir() {
local name=${1}
if [[ -z ${name} ]]; then
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
if [[ -z ${name} || ${name} == "moonraker" || ${name} == "moonraker-obico" ]]; then
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
echo "${KLIPPER_CONFIG}"
else
local re="^[1-9][0-9]*$"
@@ -39,7 +39,7 @@ function cfg_dir() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
function is_moonraker_obico_linked() {
local name=${1}
moonraker_obico_cfg="$(cfg_dir ${name})/moonraker-obico.cfg"
grep -E "^[^#]" "${moonraker_obico_cfg}" | grep -q 'auth_token'
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
grep -s -E "^[^#]" "${moonraker_obico_cfg}" | grep -q 'auth_token'
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
return $?
}
@@ -204,6 +204,7 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
### Step 7: Link to the Obico server if necessary
local not_linked_instances=()
# Refetch systemd service again since additional services may have been newly installed
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
for service in $(moonraker_obico_systemd); do
local instance_name="$(get_instance_name "${service}" moonraker_obico)"
if ! is_moonraker_obico_linked "${instance_name}"; then
@@ -212,10 +213,14 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
done
if (( ${#not_linked_instances[@]} > 0 )); then
top_border
printf "|${green}%-55s${white}|\n" " ${#not_linked_instances[@]} Moonraker-obico instances not linked to the server!"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
for name in "${not_linked_instances[@]}"; do
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
printf "|${cyan}%-57s${white}|\n" " ●moonrakerobico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
done
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
if (( moonraker_count == 1 )); then
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
printf "|${green}%-55s${white}|\n" " Moonraker-obico not linked to the server!"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
else
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
printf "|${green}%-55s${white}|\n" " ${#not_linked_instances[@]} Moonraker-obico instances not linked to the server!"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
for name in "${not_linked_instances[@]}"; do
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
printf "|${cyan}%-57s${white}|\n" " ●moonrakerobico-${name}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
done
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
fi
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
blank_line
echo -e "| To link to your Obico Server account, you need to |"
echo -e "| obtain the 6-digit verification code in the Obico |"
@@ -248,7 +253,11 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
for name in "${not_linked_instances[@]}"; do
status_msg "Link moonraker-obico-${name} to the Obico Server..."
moonraker_obico_cfg="$(cfg_dir ${name})/moonraker-obico.cfg"
"${MOONRAKER_OBICO_DIR}/scripts/link.sh" -q -n "${name}" -c "${moonraker_obico_cfg}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
if (( moonraker_count == 1 )); then
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
"${MOONRAKER_OBICO_DIR}/scripts/link.sh" -q -c "${moonraker_obico_cfg}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
else
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
"${MOONRAKER_OBICO_DIR}/scripts/link.sh" -q -n "${name}" -c "${moonraker_obico_cfg}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
fi
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
done
}
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review

See comment above :)

See comment above :)

View File

@@ -404,4 +404,4 @@ function get_octoprint_status() {
fi
echo "${status}"
}
}