feat: add Obico for Klipper to KIAUH #227
@@ -421,3 +421,18 @@ function compare_moonraker_obico_versions() {
|
||||
|
|
||||
|
||||
echo "${versions}"
|
||||
}
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
###
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
# it is possible, that moonraker_obico is installed in a so called
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
# "non-linked" state. the linking can be achieved by running the
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
# installation script again. this function will check the obico
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
# installation status and returns the correctly formulated menu title
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
#
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
function obico_install_title() {
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
if [[ $(get_moonraker_obico_status) == "Not linked!" ]]; then
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
echo "[Link to Obico Server]"
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
else
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
echo "[Obico for Klipper] "
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
fi
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
}
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
|
||||
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
This variable seems to be unused? ```ssh
local log="${KLIPPER_LOGS}"
```
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Another good catch. I guess I planed to use it but ended up using Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
Can this variable be local? Or is it required to be global? I see it only being used inside the Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
This variable seems to be unused now? This variable seems to be unused now?
This variable seems to be unused now? This variable seems to be unused now?
See comment above :) See comment above :)
See comment above :) See comment above :)
See comment above :) See comment above :)
See comment above :) See comment above :)
|
||||
@@ -12,11 +12,6 @@
|
||||
set -e
|
||||
|
||||
function install_ui() {
|
||||
local moonraker_obico_status=$(print_status "moonraker_obico") moonraker_obico_menu="[Obico for Klipper] "
|
||||
if echo ${moonraker_obico_status} | grep -q "Not linked!"; then
|
||||
moonraker_obico_menu="[Link to Obico Server]"
|
||||
fi
|
||||
|
||||
top_border
|
||||
echo -e "| ${green}~~~~~~~~~~~ [ Installation Menu ] ~~~~~~~~~~~${white} |"
|
||||
hr
|
||||
@@ -24,16 +19,16 @@ function install_ui() {
|
||||
echo -e "| all necessary dependencies for the various |"
|
||||
echo -e "| functions on a completely fresh system. |"
|
||||
hr
|
||||
echo -e "| Firmware & API: | 3rd Party Webinterface: |"
|
||||
echo -e "| 1) [Klipper] | 6) [OctoPrint] |"
|
||||
echo -e "| 2) [Moonraker] | |"
|
||||
echo -e "| | Other: |"
|
||||
echo -e "| Klipper Webinterface: | 7) [PrettyGCode] |"
|
||||
echo -e "| 3) [Mainsail] | 8) [Telegram Bot] |"
|
||||
echo -e "| 4) [Fluidd] | 9) ${moonraker_obico_menu}|"
|
||||
echo -e "| | |"
|
||||
echo -e "| Touchscreen GUI: | Webcam Streamer: |"
|
||||
echo -e "| 5) [KlipperScreen] | 10) [MJPG-Streamer] |"
|
||||
echo -e "| Firmware & API: | 3rd Party Webinterface: |"
|
||||
echo -e "| 1) [Klipper] | 6) [OctoPrint] |"
|
||||
echo -e "| 2) [Moonraker] | |"
|
||||
echo -e "| | Other: |"
|
||||
echo -e "| Klipper Webinterface: | 7) [PrettyGCode] |"
|
||||
echo -e "| 3) [Mainsail] | 8) [Telegram Bot] |"
|
||||
echo -e "| 4) [Fluidd] | 9) $(obico_install_title) |"
|
||||
echo -e "| | |"
|
||||
echo -e "| Touchscreen GUI: | Webcam Streamer: |"
|
||||
echo -e "| 5) [KlipperScreen] | 10) [MJPG-Streamer] |"
|
||||
back_footer
|
||||
}
|
||||
|
||||
|
||||
This variable seems to be unused?
This variable seems to be unused?
Another good catch. I guess I planed to use it but ended up using
"${KLIPPER_LOGS}"directly. Feel free to remove it.Another good catch. I guess I planed to use it but ended up using
"${KLIPPER_LOGS}"directly. Feel free to remove it.Can this variable be local? Or is it required to be global? I see it only being used inside the
moonraker_obico_needs_linkingfunctionCan this variable be local? Or is it required to be global? I see it only being used inside the
moonraker_obico_needs_linkingfunctionThis variable seems to be unused now?
This variable seems to be unused now?
See comment above :)
See comment above :)
See comment above :)
See comment above :)