h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat: add Obico for Klipper to KIAUH #227

Merged
kennethjiang merged 36 commits from moonraker_obico into master 2022-08-15 19:44:04 +02:00
Conversation 10 Commits 36 Files Changed 11 +5 -5
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 181a5d965a - Show all commits

10
scripts/obico.sh
View File

@@ -38,7 +38,7 @@ function cfg_dir() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
function is_moonraker_obico_linked() {
local name=${1}
moonraker_obico_cfg="$(cfg_dir ${name})/moonraker-obico.cfg"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
moonraker_obico_cfg="$(cfg_dir "${name}")/moonraker-obico.cfg"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
grep -s -E "^[^#]" "${moonraker_obico_cfg}" | grep -q 'auth_token'
return $?
}
@@ -186,13 +186,13 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
if (( moonraker_count == 1 )); then
moonraker_cfg="$(cfg_dir '')/moonraker.conf"
"${MOONRAKER_OBICO_DIR}/install.sh" -C "${moonraker_cfg}" -p ${port} -H 127.0.0.1 -l "${KLIPPER_LOGS}" -s -L -S "${obico_server_url}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
"${MOONRAKER_OBICO_DIR}/install.sh" -C "${moonraker_cfg}" -p "${port}" -H 127.0.0.1 -l "${KLIPPER_LOGS}" -s -L -S "${obico_server_url}"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
elif (( moonraker_count > 1 )); then
local j=${existing_moonraker_obico_count}
for (( i=1; i <= new_moonraker_obico_count; i++ )); do
local name=${moonraker_names[${j}]}
moonraker_cfg="$(cfg_dir ${name})/moonraker.conf"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
moonraker_cfg="$(cfg_dir "${name}")/moonraker.conf"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
"${MOONRAKER_OBICO_DIR}/install.sh" -n "${name}" -C "${moonraker_cfg}" -p $((port+j)) -H 127.0.0.1 -l "${KLIPPER_LOGS}" -s -L -S "${obico_server_url}"
j=$(( j + 1 ))
@@ -250,7 +250,7 @@ function moonraker_obico_setup_dialog() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
for name in "${not_linked_instances[@]}"; do
status_msg "Link moonraker-obico-${name} to the Obico Server..."
dw-0 commented 2022-08-14 15:44:20 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
moonraker_obico_cfg="$(cfg_dir ${name})/moonraker-obico.cfg"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
moonraker_obico_cfg="$(cfg_dir "${name}")/moonraker-obico.cfg"
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
if (( moonraker_count == 1 )); then
"${MOONRAKER_OBICO_DIR}/scripts/link.sh" -q -c "${moonraker_obico_cfg}"
else
@@ -265,7 +265,7 @@ function clone_or_update_moonraker_obico() {
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
if [[ -d ${MOONRAKER_OBICO_DIR} ]]; then
status_msg "Updating ${MOONRAKER_OBICO_DIR} ..."
cd ${MOONRAKER_OBICO_DIR} && git pull
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
cd "${MOONRAKER_OBICO_DIR}" && git pull
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
else
status_msg "Cloning Moonraker-obico from ${repo} ..."
cd "${HOME}" || exit 1
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
dw-0 commented 2022-08-13 11:51:56 +02:00 (Migrated from github.com)
Review
Copy Link
local log="${KLIPPER_LOGS}"

This variable seems to be unused?

```ssh local log="${KLIPPER_LOGS}" ``` This variable seems to be unused?
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
kennethjiang commented 2022-08-13 16:37:53 +02:00 (Migrated from github.com)
Review
Copy Link

Another good catch. I guess I planed to use it but ended up using "${KLIPPER_LOGS}" directly. Feel free to remove it.

Another good catch. I guess I planed to use it but ended up using `"${KLIPPER_LOGS}"` directly. Feel free to remove it.
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:40:07 +02:00 (Migrated from github.com)
Review
Copy Link

Can this variable be local? Or is it required to be global? I see it only being used inside the moonraker_obico_needs_linking function

Can this variable be local? Or is it required to be global? I see it only being used inside the `moonraker_obico_needs_linking` function
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:41:04 +02:00 (Migrated from github.com)
Review
Copy Link

This variable seems to be unused now?

This variable seems to be unused now?
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:14 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)
dw-0 commented 2022-08-14 15:44:24 +02:00 (Migrated from github.com)
Review
Copy Link

See comment above :)

See comment above :)