Add KlipperScreen to kiauh #44
Reference in New Issue
Block a user
Delete Branch "master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add functions to support KlipperScreen installation/removal/updating from kiauh
Looks good to me so far, if you fix those two little things i found, i think we can merge it without an issue.
@@ -305,0 +322,4 @@fi#remove KlipperScreen systemd fileif [ -e /etc/systemd/system/KlipperScreen.service ]; thenstatus_msg "Removing KlipperScreen configuration for Nginx ..."The if condition here looks like a typo.
You probably wanted to check for
[ -e /etc/systemd/system/KlipperScreen.service ].And the status_msg does not suit the action followed by it.
You probably want to call it
status_msg "Removing KlipperScreen Service ..."Do we maybe need a
start_klipperscreenhere instead?I haven't seen a
stop_klippercall before... but only astop_klipperscreen.Good catches, just pushed an update
status_msg still needs to be fixed. :)
@@ -169,0 +180,4 @@if [[ $(md5sum $KLIPPERSCREEN_DIR/scripts/KlipperScreen-requirements.txt | cut -d " " -f1) != $KLIPPERSCREEN_OLDREQ_MD5SUM ]]; thenstatus_msg "New dependecies detected..."PYTHONDIR="${HOME}/.KlipperScreen-env"$PYTHONDIR/bin/pip install -r $KLIPPERSCREEN_DIR/scripts/KlipperScreen-requirements.txtold typo gone, new typo here haha
@@ -169,0 +180,4 @@if [[ $(md5sum $KLIPPERSCREEN_DIR/scripts/KlipperScreen-requirements.txt | cut -d " " -f1) != $KLIPPERSCREEN_OLDREQ_MD5SUM ]]; thenstatus_msg "New dependecies detected..."PYTHONDIR="${HOME}/.KlipperScreen-env"$PYTHONDIR/bin/pip install -r $KLIPPERSCREEN_DIR/scripts/KlipperScreen-requirements.txtBacked that out and re-pushed it