h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

refactor(Mobileraker): update Mobileraker's companion installer script #431

Merged
Clon1998 merged 1 commits from master into master 2024-01-29 17:09:30 +01:00
Conversation 5 Commits 1 Files Changed 1 +3 -3
Clon1998 commented 2024-01-29 16:43:34 +01:00 (Migrated from github.com)
Copy Link

With the PR https://github.com/Clon1998/mobileraker_companion/pull/77 I am switching to the installer of OE.
Therefore, an update to the mobileraker.sh is required. I did not touch the removal code as it is pretty similar to what I am doing with the installer anyway.

Please wait with a merge on the PR until https://github.com/Clon1998/mobileraker_companion/pull/77 is ready

With the PR https://github.com/Clon1998/mobileraker_companion/pull/77 I am switching to the installer of OE. Therefore, an update to the `mobileraker.sh` is required. I did not touch the removal code as it is pretty similar to what I am doing with the installer anyway. Please wait with a merge on the PR until https://github.com/Clon1998/mobileraker_companion/pull/77 is ready
Clon1998 commented 2024-01-29 16:45:03 +01:00 (Migrated from github.com)
Copy Link

Especially with regards to #428, just changing the install script section and keeping the removal section is fine.

Especially with regards to #428, just changing the install script section and keeping the removal section is fine.
dw-0 commented 2024-01-29 17:09:06 +01:00 (Migrated from github.com)
Copy Link

Looks good to me :) Thank you!

Looks good to me :) Thank you!
Clon1998 commented 2024-01-29 17:11:47 +01:00 (Migrated from github.com)
Copy Link

Looks good to me :) Thank you!

Fyi, this will break kiauh for mobileraker until I merged https://github.com/Clon1998/mobileraker_companion/pull/77

> Looks good to me :) Thank you! Fyi, this will break kiauh for mobileraker until I merged https://github.com/Clon1998/mobileraker_companion/pull/77
dw-0 commented 2024-01-29 17:14:31 +01:00 (Migrated from github.com)
Copy Link

Ooops, damn, i didn't read the last paragraph of your first post. Sorry!

Ooops, damn, i didn't read the last paragraph of your first post. Sorry!
dw-0 commented 2024-01-29 17:18:28 +01:00 (Migrated from github.com)
Copy Link

I merged a revert PR to prevent that breaking change. Please notify me once that change is merged on your side and it can go live in KIAUH.

I merged a revert PR to prevent that breaking change. Please notify me once that change is merged on your side and it can go live in KIAUH.
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#431
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?