RUN_SHELL_COMMAND not working with blank characters in parameter #425

New Issue

2024-01-26T00:24:35+01:00

Duffy77 commented

2024-01-26 00:24:35 +01:00

(Migrated from github.com)

Linux Distribution

OS: Raspbian GNU/Linux 11 (bullseye)
Distro: MainsailOS 1.3.2 (bullseye)

What happened

I installed kiauh and enabled the shell command feature.
Wrote my macro to pass a text variable to a shell script.
With a simple word it works, but when i use blanks, i got the following error message

What did you expect to happen

I would like to send use parameters with whitespaces

How to reproduce

My shell_command.cfg

[gcode_shell_command GitBackup]
command: sh /home/pi/printer_data/config/test.sh
timeout: 30.
verbose: True
[gcode_macro GitBackup]
gcode:
    {% set commitmsg = params.COMMITMSG %}
    { action_respond_info("%s" % (commitmsg)) }
    RUN_SHELL_COMMAND CMD=GitBackup PARAMS={commitmsg}

my script test.sh

#!/bin/bash
if [ -n "$1" ]; then
    varname="$1"
fi

# Ask the user for their name
echo Hello, who am I talking to?

echo It\'s nice to meet you $varname

When i place a parameter with whitespaces like this

i got the following error message

Additional information

No response

### Linux Distribution OS: Raspbian GNU/Linux 11 (bullseye) Distro: MainsailOS 1.3.2 (bullseye) ### What happened I installed kiauh and enabled the shell command feature. Wrote my macro to pass a text variable to a shell script. With a simple word it works, but when i use blanks, i got the following error message ![image](https://github.com/dw-0/kiauh/assets/76178557/bcb088a2-cacd-43e8-b3fa-cbccd33f4de9) ### What did you expect to happen I would like to send use parameters with whitespaces ### How to reproduce My shell_command.cfg ``` [gcode_shell_command GitBackup] command: sh /home/pi/printer_data/config/test.sh timeout: 30. verbose: True [gcode_macro GitBackup] gcode: {% set commitmsg = params.COMMITMSG %} { action_respond_info("%s" % (commitmsg)) } RUN_SHELL_COMMAND CMD=GitBackup PARAMS={commitmsg} ``` my script test.sh ``` #!/bin/bash if [ -n "$1" ]; then varname="$1" fi # Ask the user for their name echo Hello, who am I talking to? echo It\'s nice to meet you $varname ``` When i place a parameter with whitespaces like this ![image](https://github.com/dw-0/kiauh/assets/76178557/89dda19c-ed43-4fbc-b782-c0e1b0f5e3d4) i got the following error message ![image](https://github.com/dw-0/kiauh/assets/76178557/bcb088a2-cacd-43e8-b3fa-cbccd33f4de9) ### Additional information _No response_

dw-0 commented

2024-01-27 20:50:46 +01:00

(Migrated from github.com)

did you try and add quotation marks around my test?

did you try and add quotation marks around `my test`?

Duffy77 commented

2024-01-27 21:02:53 +01:00

(Migrated from github.com)

Hi,
When I put quotation marks around my test just like 'my test' then no error occurs direkt, but my ist passed as first parameter and I think test is the second .
But this is bad, because I would like a commit message to pass as first parameter

Hi, When I put quotation marks around my test just like 'my test' then no error occurs direkt, but my ist passed as first parameter and I think test is the second . But this is bad, because I would like a commit message to pass as first parameter

dw-0 commented

2024-01-27 21:34:20 +01:00

(Migrated from github.com)

Another try would be to replace $1 with $@ in your bash script.

Another try would be to replace `$1` with `$@` in your bash script.

👍 2

Duffy77 commented

2024-01-28 00:39:49 +01:00

(Migrated from github.com)

This works :-) Thank you !

👍 2

Dalinaffeti commented

2024-03-05 13:01:10 +01:00

(Migrated from github.com)

Hi i am basically working around the same thing. I have a question after for example you have a g_code macro named: SET_PPR the param of ist named ppr. how can i use it in a g-code file. I mean how can i called and gived a value. Like example prr= 40.0

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#425