h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

fix: OctoPrint logo in README.md #424

Merged
HumbleDeer merged 4 commits from patch-1 into master 2024-01-23 22:47:37 +01:00
Conversation 7 Commits 4 Files Changed 1 +1 -1
HumbleDeer commented 2024-01-22 17:39:04 +01:00 (Migrated from github.com)
Copy Link

The OctoPrint logo on the Readme under the Sources section was broken/no longer there. This PR fixes that.

  • Fixed the broken link to the OctoPrint logo in the Readme under the Sources section. Now uses the logo present in the octoprint docs directory.
The OctoPrint logo on the Readme under the Sources section was broken/no longer there. This PR fixes that. - Fixed the broken link to the OctoPrint logo in the Readme under the Sources section. Now uses the logo present in the octoprint docs directory.
HumbleDeer commented 2024-01-22 17:39:39 +01:00 (Migrated from github.com)
Copy Link

Closed because I somehow missed the other PR. I must've not refreshed the page before I edited -- was open from before I left.

Closed because I somehow missed the other PR. I must've not refreshed the page before I edited -- was open from before I left.
HumbleDeer (Migrated from github.com) reviewed 2024-01-23 21:28:06 +01:00
README.md
HumbleDeer (Migrated from github.com) commented 2024-01-23 21:28:02 +01:00
Copy Link

add ?raw=true for full compatibility.

add `?raw=true` for full compatibility.
HumbleDeer commented 2024-01-23 22:29:32 +01:00 (Migrated from github.com)
Copy Link

@dw-0 This should be good now :)

@dw-0 This should be good now :)
dw-0 commented 2024-01-23 22:47:50 +01:00 (Migrated from github.com)
Copy Link

Awesome, thank you! @HumbleDeer

Awesome, thank you! @HumbleDeer
HumbleDeer commented 2024-01-23 22:52:59 +01:00 (Migrated from github.com)
Copy Link

@dw-0 in the future, you might want to squash merge a PR like this one. It combines all the commits into one commit, and you can choose a name for that one or keep the PR's name. Clean history tree. :)

@dw-0 in the future, you might want to squash merge a PR like this one. It combines all the commits into one commit, and you can choose a name for that one or keep the PR's name. Clean history tree. :)
dw-0 commented 2024-01-23 23:02:51 +01:00 (Migrated from github.com)
Copy Link

@HumbleDeer I did, it's the default merging strategy for PRs in this repo :)

@HumbleDeer I did, it's the default merging strategy for PRs in this repo :)
HumbleDeer commented 2024-01-23 23:35:34 +01:00 (Migrated from github.com)
Copy Link

@HumbleDeer I did, it's the default merging strategy for PRs in this repo :)

soz, my bad.

> @HumbleDeer I did, it's the default merging strategy for PRs in this repo :) soz, my bad.
Sign in to join this conversation.
Reviewers
No Reviewers
HumbleDeer
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#424
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?