h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

fix: OctoPrint logo in README.md #423

Merged
jneilliii merged 1 commits from patch-1 into master 2024-01-22 17:57:38 +01:00
Conversation 7 Commits 1 Files Changed 1 +1 -1
jneilliii commented 2024-01-22 05:34:50 +01:00 (Migrated from github.com)
Copy Link
No description provided.
HumbleDeer commented 2024-01-22 17:40:24 +01:00 (Migrated from github.com)
Copy Link

I've got an alt/dupe of this, but with the logo from the docs directory: https://github.com/dw-0/kiauh/pull/424

I've got an alt/dupe of this, but with the logo from the docs directory: https://github.com/dw-0/kiauh/pull/424
dw-0 commented 2024-01-22 17:45:04 +01:00 (Migrated from github.com)
Copy Link

I wonder which solution would be better/more future-proof. Im not sure why the image disappeared, not sure what has changed on their side.

I think we will take this approach for now. So thank you for your (both) contributions!

I wonder which solution would be better/more future-proof. Im not sure why the image disappeared, not sure what has changed on their side. I think we will take this approach for now. So thank you for your (both) contributions!
jneilliii commented 2024-01-22 18:52:59 +01:00 (Migrated from github.com)
Copy Link

I'm not exactly sure what the camo link is from, but shows as how it's linked on the readme in the repo. For direct link to github content I would probably use https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true or direct from the website maybe https://octoprint.org/assets/img/logo.png

I'm not exactly sure what the camo link is from, but shows as how it's linked on the readme in the repo. For direct link to github content I would probably use `https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true` or direct from the website maybe `https://octoprint.org/assets/img/logo.png`
dw-0 commented 2024-01-22 19:16:11 +01:00 (Migrated from github.com)
Copy Link

Honestly im not sure why i decided for the camo link in the past 😅 maybe wasn't the best idea. If it breaks again, we should rather go for one of the other links.

Honestly im not sure why i decided for the camo link in the past 😅 maybe wasn't the best idea. If it breaks again, we should rather go for one of the other links.
HumbleDeer commented 2024-01-23 21:19:56 +01:00 (Migrated from github.com)
Copy Link

For direct link to github content I would probably use https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true

You can find a solution implementing this in the PR I made. It doesn't use the raw parameter, but GitHub handles that gracefully. I obtained the nonraw link through GitHub's methods of obtaining the permalink.

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

> For direct link to github content I would probably use `https://github.com/OctoPrint/OctoPrint/blob/master/docs/images/octoprint-logo.png?raw=true` You can find a solution implementing this in the PR I made. It doesn't use the raw parameter, but GitHub handles that gracefully. I obtained the nonraw link through GitHub's methods of obtaining the permalink. I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.
dw-0 commented 2024-01-23 21:24:13 +01:00 (Migrated from github.com)
Copy Link

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards?

> I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links. Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards?
HumbleDeer commented 2024-01-23 21:26:39 +01:00 (Migrated from github.com)
Copy Link

I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links.

Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards?

Sure!

> > I also think using this link is better, because it's less likely to get purged from GitHub's CDN servers. The camo links are CDN meta-links. > > Thank you for the info @HumbleDeer, are you willing to reopen your PR, update it if necessary and we merge it afterwards? Sure!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#423
Delete Branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?