h3n3/kiauh
1
0
Fork 0
Code Issues 46 Pull Requests 10 Packages Projects Releases Wiki Activity

feat(advanced): add selection between flash/serialflash methods #410

Merged
CODeRUS merged 1 commits from serialflash into master 2023-12-10 16:57:59 +01:00
Conversation 4 Commits 1 Files Changed 1 +77 -14
CODeRUS commented 2023-12-05 13:44:02 +01:00 (Migrated from github.com)
Copy Link

Signed-off-by: Andrei Kozhevnikov coderusinbox@gmail.com

Signed-off-by: Andrei Kozhevnikov <coderusinbox@gmail.com>
dw-0 (Migrated from github.com) reviewed 2023-12-10 15:25:21 +01:00
scripts/flash_klipper.sh
dw-0 (Migrated from github.com) commented 2023-12-10 15:20:17 +01:00
Copy Link

Option "1" needs to be added as the default here, if we want to pre-fill the input with "1".

Option "1" needs to be added as the default here, if we want to pre-fill the input with "1".
dw-0 (Migrated from github.com) commented 2023-12-10 15:23:32 +01:00
Copy Link

Im unsure why you choose to display the mcu_connection_help dialog here. I think we rather should show a new help-dialog which may explains the difference between the two options selectable in that new flash_command dialog as the mcu connection dialog comes in the next step?

Im unsure why you choose to display the mcu_connection_help dialog here. I think we rather should show a new help-dialog which may explains the difference between the two options selectable in that new flash_command dialog as the mcu connection dialog comes in the next step?
CODeRUS (Migrated from github.com) reviewed 2023-12-10 16:38:05 +01:00
scripts/flash_klipper.sh
CODeRUS (Migrated from github.com) commented 2023-12-10 16:38:05 +01:00
Copy Link

Thanks, totally missed help thing, added

Thanks, totally missed help thing, added
CODeRUS (Migrated from github.com) reviewed 2023-12-10 16:38:16 +01:00
scripts/flash_klipper.sh
CODeRUS (Migrated from github.com) commented 2023-12-10 16:38:16 +01:00
Copy Link

Added default option

Added default option
dw-0 commented 2023-12-10 16:57:55 +01:00 (Migrated from github.com)
Copy Link

Thank you!

Thank you!
❤️ 1
Sign in to join this conversation.
Reviewers
No Reviewers
dw-0
CODeRUS
Labels
Clear labels
🐛 bug
Something isn't working
 can't reproduce
➕ community extension
crowsnest
duplicate
This issue or pull request already exists
 ✨ feature request
New feature or request
 fluidd
Something that is fluidd related
 improvement
improvement of existing features/code
 invalid
klipper
Something that is klipper related
 klipperscreen
Something that is klipperscreen related
 mainsail
Something that is mainsail related
 mobileraker
moonraker
Something that is moonraker related
 not kiauh
not planned
octoeverywhere
Something that is OctoEverywhere related
 ❓ question
Further information is requested
 💤 stale
todo
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
h3n3
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: h3n3/kiauh#410
Delete Branch "serialflash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?