feat: add Mobileraker #343

2023-05-27T18:36:20+02:00

Clon1998 commented

2023-05-27 18:36:20 +02:00

(Migrated from github.com)

I thought I will join the party and also add Mobileraker to Kiauh.
I manually tested install, removal, and update!
Let me know if there is something wrong or missing!

I thought I will join the party and also add Mobileraker to Kiauh. I manually tested install, removal, and update! Let me know if there is something wrong or missing!

Clon1998 commented

2023-06-08 13:05:58 +02:00

(Migrated from github.com)

Bump @th33xitus

dw-0 commented

2023-06-10 09:09:19 +02:00

(Migrated from github.com)

Hey, thanks for the PR, i will soon review, test and want to merge it. Sorry i haven't replied earlier.

dw-0 commented

2023-06-17 19:34:16 +02:00

(Migrated from github.com)

Hi! So i had a look at the PR and it looks good to me.
Two things i had to do though, i had to fix the patch_mobileraker_update_manager function as the global variable KLIPPER_CONFIG is deprecated and not used anymore. Now the function works properly again. I also went ahead and solved a merge conflict by merging the current master into this PR.

Thanks for your contribution! I hope to get your future support in case anything Mobileraker has to be resolved :)

Hi! So i had a look at the PR and it looks good to me. Two things i had to do though, i had to fix the `patch_mobileraker_update_manager` function as the global variable `KLIPPER_CONFIG` is deprecated and not used anymore. Now the function works properly again. I also went ahead and solved a merge conflict by merging the current master into this PR. Thanks for your contribution! I hope to get your future support in case anything Mobileraker has to be resolved :)

🚀 1

Clon1998 commented

2023-06-17 20:49:05 +02:00

(Migrated from github.com)

Thanks for your work!

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: h3n3/kiauh#343